detect polar with hasPolar

etpinard · etpinard · commit c009426a98e2 · 2016-05-05T16:53:01.000-04:00
diff --git a/src/plot_api/plot_api.js b/src/plot_api/plot_api.js
@@ -121,7 +121,7 @@ Plotly.plot = function(gd, data, layout, config) {
     Plots.supplyDefaults(gd);
 
     // Polar plots
-    if(data && data[0] && data[0].r) return plotPolar(gd, data, layout);
+    if(gd._fullLayout._hasPolar) return plotPolar(gd, data, layout);
 
     // so we don't try to re-call Plotly.plot from inside
     // legend and colorbar, if margins changed
diff --git a/src/plots/plots.js b/src/plots/plots.js
@@ -258,6 +258,10 @@ plots.getSubplotData = function getSubplotData(data, type, subplotId) {
 // the text is at first, so it needs to draw it,
 // then wait a little, then draw it again
 plots.redrawText = function(gd) {
+
+    // do not work for polar plots
+    if(gd._fullLayout._hasPolar) return;
+
     return new Promise(function(resolve) {
         setTimeout(function() {
             Plotly.Annotations.drawAll(gd);
@@ -472,7 +476,7 @@ plots.supplyDefaults = function(gd) {
         newFullData.push(fullTrace);
 
         // detect polar
-        if('r' in fullTrace) newFullLayout._hasPolar = true;
+        if('r' in newData[i]) newFullLayout._hasPolar = true;
 
         _module = fullTrace._module;
         if(!_module) continue;
@@ -482,6 +486,8 @@ plots.supplyDefaults = function(gd) {
         Lib.fillUnique(basePlotModules, fullTrace._module.basePlotModule);
     }
 
+    console.log(newFullLayout._hasPolar)
+
     // attach helper method
     oldFullLayout._has = hasPlotType.bind(oldFullLayout);
     newFullLayout._has = hasPlotType.bind(newFullLayout);
diff --git a/src/snapshot/index.js b/src/snapshot/index.js
@@ -15,6 +15,10 @@ function getDelay(fullLayout) {
 }
 
 function getRedrawFunc(gd) {
+
+    // do not work for polar plots
+    if(gd._fullLayout._hasPolar) return;
+
     return function() {
         (gd.calcdata || []).forEach(function(d) {
             if(d[0] && d[0].t && d[0].t.cb) d[0].t.cb();
