Remove the isCompletionCommand bypass in command_run.go so the
completion command goes through normal flag parsing. This enables
-h/--help support and proper unknown flag errors.

To prevent parent required flags from breaking the completion command,
skip required flag checks in checkAllRequiredFlags when hitting a
completion command (both its own inherited flags and parent flags).

Co-Authored-By: Claude Opus 4.6 <[email protected]>

Previously, `completion bash --help` resulted in "No help topic for
'bash'" because shell names were positional arguments, not subcommands.
Now each shell (bash, zsh, fish, pwsh) is a proper subcommand of the
completion command, making help work correctly for `completion bash --help`.

Co-Authored-By: Claude Opus 4.6 <[email protected]>

The completion command ignores global flags by design, so displaying
them in --help output is misleading. Return nil from
VisiblePersistentFlags() when isCompletionCommand is true.

Co-Authored-By: Claude Opus 4.6 <[email protected]>

The completion subcommand was using cmd.Writer which defaults to
os.Stdout instead of the root command's configured Writer. Also fix
inverted assertion in TestCompletionShell and add TestCompletionShellWriteError
to cover the Writer error path.

Co-Authored-By: Claude Opus 4.6 <[email protected]>

If the argument passed with a command isn't a sub command, there are two
checks performed - check if the command has a default command, and check
if the argument passed is a flag.
In the case that the default command doesn't exist, and the argument
passed is the name of a flag, the sub command resolves to nil, which it
was previously as well. Implying the check for the flag name doesn't
have affect the sub command resolution.

Since a default command doesn't exist, the cmd.parsedArgs list ends up
with an empty argument as its zeroth element. This commit removes the
flag name check

The merge of main into this branch silently kept incompatible halves of two
overlapping fixes (PR #2319 and this branch's earlier completion-command
work). command_run.go was still bypassing pre-parse for cmd.Name == helpName,
dropping flags on user-defined help subcommands, and checkAllRequiredFlags
had a redundant inner break.

Drop the helpName pre-parse bypass and the now-dead inner break so the state
matches the intended post-#2319 behavior.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>

Signed-off-by: Charlie Tonneslan <[email protected]>

test: regression for #2234 empty positional arg after a flag

…ag-parsing

Improve the completion command to handle flags and arguments properly

Fix 2257 - Remove incorrect flag check

Bumps the python-packages group with 1 update: [mkdocs-git-revision-date-localized-plugin](https://github.com/timvink/mkdocs-git-revision-date-localized-plugin).

Updates `mkdocs-git-revision-date-localized-plugin` from 1.5.1 to 1.5.2
- [Release notes](https://github.com/timvink/mkdocs-git-revision-date-localized-plugin/releases)
- [Commits](timvink/mkdocs-git-revision-date-localized-plugin@v1.5.1...v1.5.2)

---
updated-dependencies:
- dependency-name: mkdocs-git-revision-date-localized-plugin
  dependency-version: 1.5.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: python-packages
...

Signed-off-by: dependabot[bot] <[email protected]>

…2bfe24654

chore(deps): bump mkdocs-git-revision-date-localized-plugin from 1.5.1 to 1.5.2 in the python-packages group