fix: instant seal #29
Conversation
07b1dc4 to
0bb6631
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the project from Rococo to Paseo testnet, adds instant seal dev mode support for parachain development, and pins the Rust toolchain version. The migration standardizes currency constants and deposit calculations to match Paseo Asset Hub specifications.
Key changes:
- Switches relay chain from "rococo-local" to "paseo-local" in zombienet configuration
- Updates currency constants (UNITS, EXISTENTIAL_DEPOSIT) to match Paseo Asset Hub standards
- Implements instant seal dev mode for standalone parachain development without relay chain
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| zombienet.toml | Updates relay chain from rococo-local to paseo-local |
| rust-toolchain.toml | Pins Rust toolchain to version 1.90.0 with rustfmt and clippy |
| runtime/src/lib.rs | Updates currency constants to match Paseo Asset Hub specifications |
| runtime/src/assets_config.rs | Implements Paseo-compatible deposit calculations and removes ConstU128 usage |
| parachain-runtime/src/lib.rs | Updates currency constants and corrects comment references to MILLICENT |
| parachain-runtime/src/assets_config.rs | Implements Paseo-compatible deposit calculations (identical to runtime version) |
| node/src/service.rs | Adds new dev mode functionality with instant seal consensus |
| node/src/command.rs | Integrates instant seal mode into command handling |
| node/src/cli.rs | Adds --instant-seal CLI flag with helper method |
| node/Cargo.toml | Adds cumulus-client-parachain-inherent dependency |
| Cargo.toml | Adds cumulus-client-parachain-inherent and futures-timer dependencies |
| Cargo.lock | Updates lock file with new dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5715065 to
55f6180
Compare
55f6180 to
0a1fbfd
Compare
al3mart
left a comment
There was a problem hiding this comment.
👌 I mainly reviewed the changes for instant seal. Great work. Thanks for getting that to work!!
cmichi
left a comment
There was a problem hiding this comment.
Thanks a lot, Daan!
I tested it too. The one thing that's a bit unfortunate, but it's an implication of manual seal, is that we don't have a relaychain, so can't test contracts that require one for XCM. But I've got something in mind for that. This is already really helpful!
Follow-up to use-ink/ink-node#29.
* Update existential deposit Follow-up to use-ink/ink-node#29. * Increase partition size * Update lockfile * Update overlooked `edition`'s * Remove unnecesary toml setting * Remove unneeded todo
Fixes instant seal for the parachain.
Mimics runtime config for assets of paseo asset hub, this way devs have to write e2e tests that also work on paseo asset hub.