Reverting back to use sys_guid as current_timestamp is static when running tests as a query select * from table(ut.run())

jgebal · jgebal · commit 0089bee7e428 · 2019-03-15T01:36:05.000Z
diff --git a/source/core/types/ut_suite_item.tpb b/source/core/types/ut_suite_item.tpb
@@ -54,7 +54,7 @@ create or replace type body ut_suite_item as
   begin
     if get_rollback_type() = ut_utils.gc_rollback_auto then
       l_savepoint := ut_utils.gen_savepoint_name();
-      execute immediate 'savepoint ' || l_savepoint;
+      dbms_transaction.savepoint(l_savepoint);
     end if;
     return l_savepoint;
   end;
@@ -65,7 +65,7 @@ create or replace type body ut_suite_item as
     pragma exception_init(ex_savepoint_not_exists, -1086);
   begin
     if get_rollback_type() = ut_utils.gc_rollback_auto and a_savepoint is not null then
-      execute immediate 'rollback to ' || a_savepoint;
+      dbms_transaction.rollback_savepoint( a_savepoint );
     end if;
   exception
     when ex_savepoint_not_exists then
diff --git a/source/core/ut_utils.pkb b/source/core/ut_utils.pkb
@@ -52,7 +52,7 @@ create or replace package body ut_utils is
 
   function gen_savepoint_name return varchar2 is
   begin
-    return '"'||'s'||to_char(current_timestamp,'yyyymmddhh24missff6')||'"';
+    return '"'|| utl_raw.cast_to_varchar2(utl_encode.base64_encode(sys_guid()))||'"';
   end;
 
   procedure debug_log(a_message varchar2) is
