Merge pull request #446 from utPLSQL/feature/data_value_cursor_fix

Pazus · web-flow · commit 093006d5fae7 · 2017-08-10T07:50:43.000+03:00
Fixed a bug with comparison od ref_cursors with more than 1000 rows.
diff --git a/source/expectations/data_values/ut_data_value_refcursor.tpb b/source/expectations/data_values/ut_data_value_refcursor.tpb
@@ -70,7 +70,7 @@ create or replace type body ut_data_value_refcursor as
         l_xml := dbms_xmlgen.getxmltype(l_ctx);
 
         insert into ut_cursor_data(cursor_data_guid, row_no, row_data)
-        select self.data_value, rownum, value(a) from table( xmlsequence( extract(l_xml,'ROWSET/*') ) ) a;
+        select self.data_value, self.row_count + rownum, value(a) from table( xmlsequence( extract(l_xml,'ROWSET/*') ) ) a;
 
         exit when sql%rowcount = 0;
 
diff --git a/tests/RunAll.sql b/tests/RunAll.sql
@@ -97,7 +97,7 @@ exec ut_coverage.coverage_start_develop();
 @@lib/RunTest.sql ut_expectations/ut.expect.to_equal.cursor.ReturnsCursorDataForFailure.sql
 @@lib/RunTest.sql ut_expectations/ut.expect.to_equal.cursor.SupportsSQLandPLSQLdatatypes.sql
 @@lib/RunTest.sql ut_expectations/ut.expect.to_equal.cursor.UsesDefaultNLSSettingsForDatesFormatting.sql
-@@lib/RunTest.sql ut_expectations/ut.expect.to_equal.cursor.ReturnsCursorDataForFailure.sql
+@@lib/RunTest.sql ut_expectations/ut.expect.to_equal.cursor.worksOnLargeDatasets.sql
 @@ut_expectations/ut.expect.to_equal.GivesFailureForDifferentDataTypes.sql
 @@ut_expectations/ut.expect.to_equal.GivesFailureForDifferentValues.sql
 @@ut_expectations/ut.expect.to_equal.GivesFailureWhenActualIsNull.sql
diff --git a/tests/ut_expectations/ut.expect.to_equal.cursor.worksOnLargeDatasets.sql b/tests/ut_expectations/ut.expect.to_equal.cursor.worksOnLargeDatasets.sql
@@ -0,0 +1,21 @@
+--Arrange
+declare
+  l_actual   sys_refcursor;
+  l_expected sys_refcursor;
+  l_result   integer;
+begin
+--Act
+  open l_actual for select object_name from all_objects where rownum <=1100;
+  open l_expected for select object_name from all_objects where rownum <=1100;
+  ut.expect(l_actual).to_equal(l_expected);
+
+--Assert
+  l_result :=  ut_expectation_processor.get_status();
+--Assert
+  if l_result = ut_utils.tr_success then
+      :test_result := ut_utils.tr_success;
+  else
+    dbms_output.put_line('expected 1 data and got: '||l_result );
+  end if;
+end;
+/
