Fixed issue when user execution tests doesn't have access to DBA_TYPES view.

jgebal · jgebal · commit 0a00fd8bfe3c · 2018-04-07T10:19:17.000+01:00
Fixed missing grants for non-instantiable reporters causing reporters not to show on list of available reporters when DBA_TYPES view not accessible.
diff --git a/source/api/ut_runner.pkb b/source/api/ut_runner.pkb
@@ -144,38 +144,34 @@ create or replace package body ut_runner is
     return;
   end;
 
-  function get_reporters_list return tt_reporters_info pipelined
-  AS
+  function get_reporters_list return tt_reporters_info pipelined is
     l_cursor      sys_refcursor;
-    l_owner  varchar2(128) := ut_utils.ut_owner();
+    l_owner       varchar2(128) := upper(ut_utils.ut_owner());
     l_results     tt_reporters_info;
     c_bulk_limit  constant integer := 10;
-    begin
-      open l_cursor for 'SELECT
-          owner || ''.'' || type_name,
-          CASE
-                  WHEN sys_connect_by_path(owner
-                  || ''.''
-                  || type_name,'','') LIKE ''%' || l_owner || '''
-                  || ''.UT_OUTPUT_REPORTER_BASE%'' THEN ''Y''
-                  ELSE ''N''
-              END
-          is_output_reporter
-      FROM dba_types t
-      WHERE instantiable = ''YES''
-      CONNECT BY supertype_name = PRIOR type_name AND supertype_owner = PRIOR owner
-        START WITH type_name = ''UT_REPORTER_BASE'' AND owner = '''|| l_owner || '''';
-      loop
-        fetch l_cursor bulk collect into l_results limit c_bulk_limit;
-        for i in 1 .. l_results.count loop
-          pipe row (l_results(i));
-        end loop;
-        exit when l_cursor%notfound;
+    l_view_name   varchar2(200) := ut_metadata.get_dba_view('dba_types');
+  begin
+    open l_cursor for q'[
+      SELECT
+        owner || '.' || type_name,
+        CASE
+          WHEN sys_connect_by_path(owner||'.'||type_name,',') LIKE '%]' || l_owner || q'[.UT_OUTPUT_REPORTER_BASE%'
+          THEN 'Y'
+          ELSE 'N'
+        END is_output_reporter
+      FROM ]'||l_view_name||q'[ t
+     WHERE instantiable = 'YES'
+     CONNECT BY supertype_name = PRIOR type_name AND supertype_owner = PRIOR owner
+       START WITH type_name = 'UT_REPORTER_BASE' AND owner = ']'|| l_owner || '''';
+    loop
+      fetch l_cursor bulk collect into l_results limit c_bulk_limit;
+      for i in 1 .. l_results.count loop
+        pipe row (l_results(i));
       end loop;
-      close l_cursor;
-    end;
-
-
+      exit when l_cursor%notfound;
+    end loop;
+    close l_cursor;
+  end;
 
 end ut_runner;
 /
diff --git a/source/create_synonyms_and_grants_for_public.sql b/source/create_synonyms_and_grants_for_public.sql
@@ -61,6 +61,8 @@ grant execute on &&ut3_owner..ut_varchar2_rows to public;
 grant execute on &&ut3_owner..ut_integer_list to public;
 grant execute on &&ut3_owner..ut_reporter_base to public;
 grant execute on &&ut3_owner..ut_output_reporter_base to public;
+grant execute on &&ut3_owner..ut_coverage_reporter_base to public;
+grant execute on &&ut3_owner..ut_console_reporter_base to public;
 grant execute on &&ut3_owner..ut_coverage to public;
 grant execute on &&ut3_owner..ut_coverage_options to public;
 grant execute on &&ut3_owner..ut_coverage_helper to public;
diff --git a/source/create_synonyms_and_grants_for_user.sql b/source/create_synonyms_and_grants_for_user.sql
@@ -81,6 +81,8 @@ grant execute on &&ut3_owner..ut_varchar2_rows to &ut3_user;
 grant execute on &&ut3_owner..ut_integer_list to &ut3_user;
 grant execute on &&ut3_owner..ut_reporter_base to &ut3_user;
 grant execute on &&ut3_owner..ut_output_reporter_base to &ut3_user;
+grant execute on &&ut3_owner..ut_coverage_reporter_base to &ut3_user;
+grant execute on &&ut3_owner..ut_console_reporter_base to &ut3_user;
 grant execute on &&ut3_owner..ut_coverage to &ut3_user;
 grant execute on &&ut3_owner..ut_coverage_options to &ut3_user;
 grant execute on &&ut3_owner..ut_coverage_helper to &ut3_user;
