Merge branch 'develop' into feature/refactoing_assert_to_expectation

jgebal · jgebal · commit 15dbdea55af1 · 2017-04-21T01:11:09.000+01:00
diff --git a/docs/userguide/install.md b/docs/userguide/install.md
@@ -85,6 +85,13 @@ The following tools that support the SQL*Plus commands can be used to run the in
   - [SQLcl](http://www.oracle.com/technetwork/developer-tools/sqlcl/overview/index.html)
   - [Oracle SQL Developer](http://www.oracle.com/technetwork/developer-tools/sql-developer/overview/index.html)
  
+# Additional requirements
+
+In order to use Code Coverage functionality of utPLSQL users executing the tests must have the CREATE privilege on the PLSQL code that the coverage is gathered on.
+This is a requirement of [DBMS_PROFILER package](https://docs.oracle.com/cd/E18283_01/appdev.112/e16760/d_profil.htm#i999476).
+
+In practice, user running tests for PLSQL code that he does not own, needs to have CREATE ANY PROCEDURE/CREATE ANY TRIGGER privileges.
+Running code coverage on objects that the user does not own will not produce any coverage information without those privileges.
 
 # Uninstalling utPLSQL
 
diff --git a/source/core/ut_output_buffer.pkb b/source/core/ut_output_buffer.pkb
@@ -55,27 +55,32 @@ create or replace package body ut_output_buffer is
   end;
 
   function get_lines(a_reporter_id varchar2, a_timeout_sec naturaln := gc_max_wait_sec) return ut_varchar2_rows pipelined is
-    pragma autonomous_transaction;
-    l_results        ut_varchar2_rows;
+    l_buffer_data    ut_varchar2_rows;
     l_wait_wait_time number(10,1) := 0;
     l_finished       boolean := false;
-  begin
-    loop
+    function get_data_from_buffer return ut_varchar2_rows is
+      l_results        ut_varchar2_rows;
+      pragma autonomous_transaction;
+    begin
       delete from (
         select *
           from ut_output_buffer_tmp where reporter_id = a_reporter_id order by message_id
         )
       returning text bulk collect into l_results;
-
+      commit;
+      return l_results;
+    end;
+  begin
+    loop
+      l_buffer_data := get_data_from_buffer();
       --nothing fetched from output, wait and try again
-      if l_results.count = 0 then
+      if l_buffer_data.count = 0 then
         dbms_lock.sleep(gc_sleep_time);
         l_wait_wait_time := l_wait_wait_time + gc_sleep_time;
       else
-        commit;
-        for i in 1 .. l_results.count loop
-          if l_results(i) is not null then
-            pipe row(l_results(i));
+        for i in 1 .. l_buffer_data.count loop
+          if l_buffer_data(i) is not null then
+            pipe row(l_buffer_data(i));
           else
             l_finished := true;
             exit;
diff --git a/source/core/ut_suite_manager.pkb b/source/core/ut_suite_manager.pkb
@@ -15,7 +15,7 @@ create or replace package body ut_suite_manager is
   See the License for the specific language governing permissions and
   limitations under the License.
   */
-  
+
   type t_schema_info is record (changed_at date, obj_cnt integer);
 
   type tt_schema_suites is table of ut_logical_suite index by varchar2(4000 char);
@@ -63,11 +63,17 @@ create or replace package body ut_suite_manager is
 
     l_suite_rollback            integer;
     l_suite_rollback_annotation varchar2(4000);
-
+    e_insufficient_priv         exception;
+    pragma exception_init(e_insufficient_priv,-01031);
   begin
     l_owner_name  := a_owner_name;
     l_object_name := a_object_name;
-    ut_metadata.do_resolve(a_owner => l_owner_name, a_object => l_object_name);
+    begin
+      ut_metadata.do_resolve(a_owner => l_owner_name, a_object => l_object_name);
+    exception
+      when e_insufficient_priv then
+      return null;
+    end;
     l_annotation_data := ut_annotations.get_package_annotations(a_owner_name => l_owner_name, a_name => l_object_name);
 
     if l_annotation_data.package_annotations.exists('suite') then
