Interim commit some fixes to old tests, examples and code itself.

jgebal · jgebal · commit 1611e09b15c5 · 2018-11-04T18:30:31.000Z
One problem to be solved. Oracle nested tables are **unordered!** and we need an ordered list of before/after items that contain CLOB column, so cannot be varray.
diff --git a/examples/developer_examples/RunExampleComplexSuiteWithCustomReporter.sql b/examples/developer_examples/RunExampleComplexSuiteWithCustomReporter.sql
@@ -22,8 +22,8 @@ begin
   ut_event_manager.initialize();
   l_parent_suite := ut_logical_suite( a_object_owner=>null, a_object_name => null, a_name => 'complex_test_suite', a_path => null);
 
-  l_suite := ut_suite(user, 'ut_exampletest');
-  l_test := ut_test(user, 'ut_exampletest','ut_exAmpletest');
+  l_suite := ut_suite(user, 'ut_exampletest',a_line_no=>1);
+  l_test := ut_test(user, 'ut_exampletest','ut_exAmpletest',a_line_no=>3);
   l_test.description      := 'Example test1';
   l_test.before_test_list := ut_executables(ut_executable(user, 'ut_exampletest','Setup',ut_utils.gc_before_test));
   l_test.after_test_list  := ut_executables(ut_executable(user, 'ut_exampletest','tEardown',ut_utils.gc_after_test));
@@ -32,8 +32,8 @@ begin
   l_parent_suite.add_item(l_suite);
 
 
-  l_suite := ut_suite(user, 'ut_exampletest2');
-  l_test := ut_test(user, 'UT_EXAMPLETEST2','UT_EXAMPLETEST');
+  l_suite := ut_suite(user, 'ut_exampletest2',a_line_no=>1);
+  l_test := ut_test(user, 'UT_EXAMPLETEST2','UT_EXAMPLETEST',a_line_no=>3);
   l_test.before_test_list := ut_executables(ut_executable(user, 'UT_EXAMPLETEST2','SETUP',ut_utils.gc_before_test));
   l_test.after_test_list  := ut_executables(ut_executable(user, 'UT_EXAMPLETEST2','TEARDOWN',ut_utils.gc_after_test));
 
diff --git a/examples/developer_examples/RunExampleTestSuite.sql b/examples/developer_examples/RunExampleTestSuite.sql
@@ -15,15 +15,15 @@ declare
   l_test          ut_test;
   l_expectation   ut_expectation_result;
 begin
-  l_suite := ut_suite(user, 'ut_exampletest');
+  l_suite := ut_suite(user, 'ut_exampletest',a_line_no=>1);
   l_suite.description := 'Test Suite Name';
-  l_test := ut_test(user, 'ut_exampletest','ut_exAmpletest');
+  l_test := ut_test(user, 'ut_exampletest','ut_exAmpletest',a_line_no=>3);
   l_test.description := 'Example test1';
   l_test.before_test_list := ut_executables(ut_executable(user, 'ut_exampletest','Setup',ut_utils.gc_before_test));
   l_test.after_test_list  := ut_executables(ut_executable(user, 'ut_exampletest','tEardown',ut_utils.gc_after_test));
   l_suite.add_item(l_test);
 
-  l_test := ut_test(user, 'UT_EXAMPLETEST2','ut_exAmpletest');
+  l_test := ut_test(user, 'UT_EXAMPLETEST2','ut_exAmpletest',a_line_no=>6);
   l_test.description := 'Another example test';
   l_test.before_test_list := ut_executables(ut_executable(user, 'UT_EXAMPLETEST2','SETUP',ut_utils.gc_before_test));
   l_test.after_test_list  := ut_executables(ut_executable(user, 'UT_EXAMPLETEST2','TEARDOWN',ut_utils.gc_after_test));
diff --git a/examples/developer_examples/RunExampleTestSuiteWithCompositeReporter.sql b/examples/developer_examples/RunExampleTestSuiteWithCompositeReporter.sql
@@ -21,11 +21,11 @@ begin
   ut_event_manager.add_listener(l_doc_reporter);
   ut_event_manager.add_listener(l_tc_reporter);
 
-  suite := ut_suite(user, 'ut_exampletest');
+  suite := ut_suite(user, 'ut_exampletest',a_line_no=>1);
   suite.description := 'Test Suite Name';
 
-  suite.add_item(ut_test(user,'ut_exampletest','ut_exAmpletest'));
-  suite.add_item(ut_test(user, 'UT_EXAMPLETEST2','UT_EXAMPLETEST'));
+  suite.add_item(ut_test(user,'ut_exampletest','ut_exAmpletest',a_line_no=>3));
+  suite.add_item(ut_test(user, 'UT_EXAMPLETEST2','UT_EXAMPLETEST',a_line_no=>6));
 
   -- provide a reporter to process results
   l_run := ut_run(ut_suite_items(suite));
diff --git a/examples/developer_examples/RunExampleTestSuiteWithCustomReporter.sql b/examples/developer_examples/RunExampleTestSuiteWithCustomReporter.sql
@@ -22,15 +22,15 @@ begin
   ut_event_manager.initialize();
   -- Install ut_custom_reporter first from example folder
 
-  l_suite := ut_suite(user, 'ut_exampletest');
+  l_suite := ut_suite(user, 'ut_exampletest',a_line_no=>1);
 
-  l_test := ut_test(user, 'ut_exampletest','ut_exAmpletest');
+  l_test := ut_test(user, 'ut_exampletest','ut_exAmpletest',a_line_no=>3);
   l_test.description := 'Example test1';
   l_test.before_test_list := ut_executables(ut_executable(user, 'ut_exampletest','Setup',ut_utils.gc_before_test));
   l_test.after_test_list  := ut_executables(ut_executable(user, 'ut_exampletest','tEardown',ut_utils.gc_after_test));
   l_suite.add_item(l_test);
 
-  l_test := ut_test(user, 'UT_EXAMPLETEST2','ut_exAmpletest');
+  l_test := ut_test(user, 'UT_EXAMPLETEST2','ut_exAmpletest',a_line_no=>6);
   l_test.description := 'Another example test';
   l_test.before_test_list := ut_executables(ut_executable(user, 'ut_exampletest','SETUP',ut_utils.gc_before_test));
   l_test.after_test_list  := ut_executables(ut_executable(user, 'ut_exampletest','TEARDOWN',ut_utils.gc_after_test));
diff --git a/old_tests/ut_reporters/ut_documentation_reporter.providesCorrectLineFromStacktrace.sql b/old_tests/ut_reporters/ut_documentation_reporter.providesCorrectLineFromStacktrace.sql
@@ -18,7 +18,7 @@ Finished %
   --act
   select *
   bulk collect into l_output_data
-  from table(ut.run('test_reporters',ut_documentation_reporter()));
+  from table(ut.run(':org.utplsql.utplsql.test.test_reporters',ut_documentation_reporter()));
 
   l_output := ut_utils.table_to_clob(l_output_data);
 
diff --git a/old_tests/ut_suite_manager/ut_suite_manager.CacheInvalidaesOnPackageDrop.sql b/old_tests/ut_suite_manager/ut_suite_manager.CacheInvalidaesOnPackageDrop.sql
@@ -28,19 +28,23 @@ drop package tst_package_to_be_dropped
 set termout on
 
 declare
-  l_test_report ut_varchar2_list;
+  l_test_report   ut_varchar2_list;
+  l_error_message varchar2(4000);
+  l_expected      varchar2(4000);
 begin
+  l_expected := '%tst_package_to_be_dropped%does not exist%';
   begin
     select * bulk collect into l_test_report from table(ut.run(user || '.tst_package_to_be_dropped'));
   exception
     when others then
-      if sqlerrm like '%tst_package_to_be_dropped%not found%' then
+      l_error_message := sqlerrm;
+      if l_error_message like l_expected then
         :test_result := ut_utils.gc_success;
       end if;
   end;
   if :test_result != ut_utils.gc_success or :test_result is null then
-    dbms_output.put_line('Failed: Expected exception with text like ''%tst_package_to_be_dropped%not found%'' but got:''' ||
-                         sqlerrm || '''');
+    dbms_output.put_line('Failed: Expected exception with text like '''||l_expected||''' but got:''' ||
+                           l_error_message || '''');
   end if;
 end;
 /
diff --git a/old_tests/ut_suite_manager/ut_suite_manager.get_schema_ut_packages.IncludesPackagesWithSutePath.sql b/old_tests/ut_suite_manager/ut_suite_manager.get_schema_ut_packages.IncludesPackagesWithSutePath.sql
@@ -6,8 +6,9 @@ end;
 set termout on
 
 declare
-  l_expected ut_object_names;
-  l_actual   ut_object_names;
+  l_expected  ut_object_names;
+  l_actual    ut_object_names;
+  l_not_found ut_object_names := ut_object_names();
 begin
   l_expected := ut_object_names(
     ut_object_name(user,'TEST_PACKAGE_1'),
@@ -17,7 +18,13 @@ begin
     ut_object_name(user,'TEST_REPORTERS')
   );
   l_actual := ut_suite_manager.get_schema_ut_packages(ut_varchar2_rows(user));
-  if l_actual = l_expected then
+  for i in 1 .. l_expected.count loop
+    if l_expected(i) not member of l_actual then
+      l_not_found.extend;
+      l_not_found(l_not_found.last) := l_expected(i);
+    end if;
+  end loop;
+  if l_not_found is empty then
     :test_result := ut_utils.gc_success;
   else
     dbms_output.put_line('actual:'||xmltype(anydata.convertcollection(l_actual)).getclobval());
diff --git a/old_tests/ut_test/ut_test.AfterEachExecuted.sql b/old_tests/ut_test/ut_test.AfterEachExecuted.sql
@@ -3,8 +3,9 @@ PROMPT Invoke aftereach procedure
 --Arrange
 declare
   simple_test ut_test := ut_test(
-    a_object_name         => 'ut_example_tests'
-    ,a_name     => 'ut_passing_test'
+    a_object_name  => 'ut_example_tests',
+    a_name     => 'ut_passing_test',
+    a_line_no => null
   );
 begin
   simple_test.after_each_list := ut_executables(ut_executable(user, 'ut_example_tests', 'aftereach', ut_utils.gc_after_each));
diff --git a/old_tests/ut_test/ut_test.AfterEachProcedureNameInvalid.sql b/old_tests/ut_test/ut_test.AfterEachProcedureNameInvalid.sql
@@ -3,8 +3,9 @@ PROMPT Does not execute test and reports error when test aftereach procedure nam
 --Arrange
 declare
   simple_test ut_test := ut_test(
-    a_object_name => 'ut_example_tests'
-    ,a_name => 'ut_exampletest'
+    a_object_name => 'ut_example_tests',
+    a_name => 'ut_exampletest',
+    a_line_no => null
   );
 begin
   simple_test.after_each_list := ut_executables(ut_executable(user, 'ut_example_tests', 'invalid setup name', ut_utils.gc_after_each));
diff --git a/old_tests/ut_test/ut_test.AfterEachProcedureNameNull.sql b/old_tests/ut_test/ut_test.AfterEachProcedureNameNull.sql
@@ -3,8 +3,9 @@ PROMPT Does not invoke aftereach procedure when aftereach procedure name for a t
 --Arrange
 declare
   simple_test ut_test := ut_test(
-    a_object_name => 'ut_example_tests'
-    ,a_name => 'ut_passing_test'
+    a_object_name => 'ut_example_tests',
+    a_name => 'ut_passing_test',
+    a_line_no => null
   );
 begin
   simple_test.after_each_list := ut_executables(ut_executable(user, 'ut_example_tests', '', ut_utils.gc_after_each));
diff --git a/old_tests/ut_test/ut_test.BeforeEachExecuted.sql b/old_tests/ut_test/ut_test.BeforeEachExecuted.sql
@@ -3,8 +3,9 @@ PROMPT Invoke beforeeach procedure
 --Arrange
 declare
   simple_test ut_test := ut_test(
-    a_object_name  => 'ut_example_tests'
-    ,a_name        => 'ut_passing_test'
+    a_object_name  => 'ut_example_tests',
+    a_name        => 'ut_passing_test',
+    a_line_no => null
   );
 begin
   simple_test.before_each_list := ut_executables(ut_executable(user, 'ut_example_tests', 'beforeeach', ut_utils.gc_before_each));
diff --git a/old_tests/ut_test/ut_test.BeforeEachProcedureNameInvalid.sql b/old_tests/ut_test/ut_test.BeforeEachProcedureNameInvalid.sql
@@ -3,8 +3,9 @@ PROMPT Does not execute test and reports error when test beforeeach procedure na
 --Arrange
 declare
   simple_test ut_test := ut_test(
-     a_object_name => 'ut_example_tests'
-    ,a_name => 'ut_exampletest'
+    a_object_name => 'ut_example_tests',
+    a_name => 'ut_exampletest',
+    a_line_no => null
   );
 begin
   simple_test.before_each_list := ut_executables(ut_executable(user, 'ut_example_tests', 'invalid setup name', ut_utils.gc_before_each));
diff --git a/old_tests/ut_test/ut_test.BeforeEachProcedureNameNull.sql b/old_tests/ut_test/ut_test.BeforeEachProcedureNameNull.sql
@@ -3,8 +3,9 @@ PROMPT Does not invoke setup procedure when beforeeach procedure name for a test
 --Arrange
 declare
   simple_test ut_test := ut_test(
-    a_object_name => 'ut_example_tests'
-    ,a_name => 'ut_passing_test'
+    a_object_name => 'ut_example_tests',
+    a_name => 'ut_passing_test',
+    a_line_no => null
   );
 begin
   simple_test.before_each_list := ut_executables(ut_executable(user, 'ut_example_tests', '', ut_utils.gc_before_each));
diff --git a/old_tests/ut_test/ut_test.IgnoreTollbackToSavepointException.sql b/old_tests/ut_test/ut_test.IgnoreTollbackToSavepointException.sql
@@ -2,7 +2,7 @@ PROMPT Checks that rollback exception does not make run to fail
 
 --Arrange
 declare
-	simple_test ut_test := ut_test(a_object_name => 'ut_example_tests', a_name => 'ut_commit_test');
+	simple_test ut_test := ut_test(a_object_name => 'ut_example_tests', a_name => 'ut_commit_test', a_line_no => null);
 begin
   simple_test.rollback_type := ut_utils.gc_rollback_auto;
 --Act
diff --git a/old_tests/ut_test/ut_test.OwnerNameInvalid.sql b/old_tests/ut_test/ut_test.OwnerNameInvalid.sql
@@ -2,7 +2,11 @@ PROMPT Reports error when test owner name for a test is invalid
 
 --Arrange
 declare
-  simple_test ut_test := ut_test( a_object_owner => 'invalid owner name', a_object_name => 'ut_example_tests', a_name => 'ut_passing_test');
+  simple_test ut_test := ut_test(
+    a_object_owner => 'invalid owner name',
+    a_object_name => 'ut_example_tests',
+    a_name => 'ut_passing_test',
+    a_line_no => null);
 begin
 --Act
   simple_test.do_execute();
diff --git a/old_tests/ut_test/ut_test.OwnerNameNull.sql b/old_tests/ut_test/ut_test.OwnerNameNull.sql
@@ -2,7 +2,11 @@ PROMPT Executes test in current schema when test owner name for a test is null
 
 --Arrange
 declare
-  simple_test ut_test:= ut_test(a_object_owner => null, a_object_name => 'ut_example_tests', a_name => 'ut_passing_test');
+  simple_test ut_test:= ut_test(
+    a_object_owner => null,
+    a_object_name => 'ut_example_tests',
+    a_name => 'ut_passing_test',
+    a_line_no => null);
 begin
 --Act
   simple_test.do_execute();
diff --git a/old_tests/ut_test/ut_test.PackageInInvalidState.sql b/old_tests/ut_test/ut_test.PackageInInvalidState.sql
@@ -8,7 +8,7 @@ end;
 set termout on
 
 declare
-	simple_test ut_test := ut_test(a_object_name => 'invalid_package', a_name => 'ut_exampletest');
+	simple_test ut_test := ut_test(a_object_name => 'invalid_package', a_name => 'ut_exampletest', a_line_no => null);
 begin
 --Act
 	simple_test.do_execute();
diff --git a/old_tests/ut_test/ut_test.PackageNameInvalid.sql b/old_tests/ut_test/ut_test.PackageNameInvalid.sql
@@ -2,7 +2,7 @@ PROMPT Reports error when unit test package name for a test is invalid
 
 --Arrange
 declare
-	simple_test ut_test := ut_test(a_object_name => 'invalid test package name', a_name => 'ut_passing_test');
+	simple_test ut_test := ut_test(a_object_name => 'invalid test package name', a_name => 'ut_passing_test', a_line_no => null);
 begin
 --Act
 	simple_test.do_execute();
diff --git a/old_tests/ut_test/ut_test.PackageNameNull.sql b/old_tests/ut_test/ut_test.PackageNameNull.sql
@@ -2,7 +2,7 @@ PROMPT Reports error when unit test package name for a test is null
 
 --Arrange
 declare
-	simple_test ut_test := ut_test(a_object_name => null, a_name => 'ut_passing_test');
+	simple_test ut_test := ut_test(a_object_name => null, a_name => 'ut_passing_test', a_line_no => null);
 begin
 --Act
 	simple_test.do_execute();
diff --git a/old_tests/ut_test/ut_test.ProcedureNameInvalid.sql b/old_tests/ut_test/ut_test.ProcedureNameInvalid.sql
@@ -2,7 +2,7 @@ PROMPT Reports error when test procedure name for a test is invalid
 
 --Arrange
 declare
-  simple_test ut_test := ut_test(a_object_name => 'ut_example_tests' ,a_name => 'invalid procedure name');
+  simple_test ut_test := ut_test(a_object_name => 'ut_example_tests' ,a_name => 'invalid procedure name', a_line_no => null);
 begin
 --Act
   simple_test.do_execute();
diff --git a/old_tests/ut_test/ut_test.ProcedureNameNull.sql b/old_tests/ut_test/ut_test.ProcedureNameNull.sql
@@ -2,7 +2,7 @@ PROMPT Reports error when test procedure name for a test is null
 
 --Arrange
 declare
-  simple_test ut_test := ut_test(a_object_name => 'ut_example_tests', a_name => null);
+  simple_test ut_test := ut_test(a_object_name => 'ut_example_tests', a_name => null, a_line_no => null);
 begin
 --Act
   simple_test.do_execute();
diff --git a/old_tests/ut_test/ut_test.SetupExecutedBeforeTest.sql b/old_tests/ut_test/ut_test.SetupExecutedBeforeTest.sql
@@ -3,8 +3,9 @@ PROMPT Invoke setup procedure before test when setup procedure name is defined
 --Arrange
 declare
   simple_test ut_test := ut_test(
-    a_object_name            => 'ut_example_tests'
-    ,a_name        => 'ut_passing_test'
+    a_object_name            => 'ut_example_tests',
+    a_name        => 'ut_passing_test',
+    a_line_no => null
   );
 begin
   simple_test.before_test_list := ut_executables(ut_executable(user, 'ut_example_tests', 'setup', ut_utils.gc_before_test));
diff --git a/old_tests/ut_test/ut_test.SetupProcedureNameInvalid.sql b/old_tests/ut_test/ut_test.SetupProcedureNameInvalid.sql
@@ -3,8 +3,9 @@ PROMPT Does not execute test and reports error when test setup procedure name fo
 --Arrange
 declare
   simple_test ut_test := ut_test(
-     a_object_name => 'ut_example_tests'
-    ,a_name => 'ut_exampletest'
+    a_object_name => 'ut_example_tests',
+    a_name => 'ut_exampletest',
+    a_line_no => null
   );
 begin
   simple_test.before_test_list := ut_executables(ut_executable(user, 'ut_example_tests', 'invalid setup name', ut_utils.gc_before_test));
diff --git a/old_tests/ut_test/ut_test.SetupProcedureNameNull.sql b/old_tests/ut_test/ut_test.SetupProcedureNameNull.sql
@@ -3,8 +3,9 @@ PROMPT Does not invoke setup procedure when setup procedure name for a test is n
 --Arrange
 declare
   simple_test ut_test := ut_test(
-     a_object_name => 'ut_example_tests'
-    ,a_name => 'ut_passing_test'
+    a_object_name => 'ut_example_tests',
+    a_name => 'ut_passing_test',
+    a_line_no => null
   );
 begin
   simple_test.before_test_list := ut_executables(ut_executable(user, 'ut_example_tests', null, ut_utils.gc_before_test));
diff --git a/old_tests/ut_test/ut_test.TeardownExecutedAfterTest.sql b/old_tests/ut_test/ut_test.TeardownExecutedAfterTest.sql
@@ -3,8 +3,9 @@ PROMPT Invoke teardown procedure after test when teardown procedure name is defi
 --Arrange
 declare
   simple_test ut_test := ut_test(
-    a_object_name         => 'ut_example_tests'
-    ,a_name     => 'ut_passing_test'
+    a_object_name         => 'ut_example_tests',
+    a_name     => 'ut_passing_test',
+    a_line_no => null
   );
 begin
   simple_test.after_test_list := ut_executables(ut_executable(user, 'ut_example_tests', 'teardown', ut_utils.gc_after_test));
diff --git a/old_tests/ut_test/ut_test.TeardownProcedureNameInvalid.sql b/old_tests/ut_test/ut_test.TeardownProcedureNameInvalid.sql
@@ -3,8 +3,9 @@ PROMPT Does not execute test and reports error when test teardown procedure name
 --Arrange
 declare
   simple_test ut_test := ut_test(
-    a_object_name => 'ut_example_tests'
-    ,a_name => 'ut_exampletest'
+    a_object_name => 'ut_example_tests',
+    a_name => 'ut_exampletest',
+    a_line_no => null
   );
 begin
   simple_test.after_test_list := ut_executables(ut_executable(user, 'ut_example_tests', 'invalid setup name', ut_utils.gc_after_test));
diff --git a/old_tests/ut_test/ut_test.TeardownProcedureNameNull.sql b/old_tests/ut_test/ut_test.TeardownProcedureNameNull.sql
@@ -3,8 +3,9 @@ PROMPT Does not invoke teardown procedure when teardown procedure name for a tes
 --Arrange
 declare
   simple_test ut_test := ut_test(
-    a_object_name => 'ut_example_tests'
-    ,a_name => 'ut_passing_test'
+    a_object_name => 'ut_example_tests',
+    a_name => 'ut_passing_test',
+    a_line_no => null
   );
 begin
   simple_test.after_test_list := ut_executables(ut_executable(user, 'ut_example_tests', null, ut_utils.gc_after_test));
diff --git a/source/core/annotations/ut_annotation_cache_seq.sql b/source/core/annotations/ut_annotation_cache_seq.sql
@@ -12,5 +12,5 @@ create sequence ut_annotation_cache_seq
   See the License for the specific language governing permissions and
   limitations under the License.
   */
-cache 20;
+cache 100;
 
diff --git a/source/core/ut_suite_builder.pkb b/source/core/ut_suite_builder.pkb
diff --git a/source/core/ut_suite_cache.sql b/source/core/ut_suite_cache.sql
diff --git a/source/core/ut_suite_cache_manager.pkb b/source/core/ut_suite_cache_manager.pkb
diff --git a/source/core/ut_suite_cache_manager.pks b/source/core/ut_suite_cache_manager.pks
diff --git a/source/core/ut_suite_cache_package.sql b/source/core/ut_suite_cache_package.sql
diff --git a/source/core/ut_suite_cache_seq.sql b/source/core/ut_suite_cache_seq.sql
diff --git a/source/create_synonyms_and_grants_for_public.sql b/source/create_synonyms_and_grants_for_public.sql
diff --git a/source/create_user_grants.sql b/source/create_user_grants.sql
diff --git a/source/install.sql b/source/install.sql
diff --git a/test/core/test_suite_builder.pkb b/test/core/test_suite_builder.pkb
