Merge pull request #41 from jgebal/feature/unit_tests

rlove · web-flow · commit 26cd40021b2c · 2016-08-22T10:45:32.000-06:00
Feature/unit tests
diff --git a/source/ut_metadata.pkb b/source/ut_metadata.pkb
@@ -27,12 +27,12 @@ create or replace package body ut_metadata as
   function form_name(a_owner_name varchar2, a_object varchar2, a_subprogram varchar2 default null) return varchar2 is
     l_name varchar2(200);
   begin
-    l_name := a_object;
+    l_name := trim(a_object);
     if trim(a_owner_name) is not null then
       l_name := trim(a_owner_name) || '.' || l_name;
     end if;
     if trim(a_subprogram) is not null then
-      l_name := l_name || '.' || a_subprogram;
+      l_name := l_name || '.' || trim(a_subprogram);
     end if;
     return l_name;
   end form_name;
diff --git a/tests/RunAll.sql b/tests/RunAll.sql
@@ -1,5 +1,6 @@
 set echo off
 set feedback off
+set verify off
 Clear Screen
 set serveroutput on size unlimited format truncated
 @@lib/RunVars.sql
@@ -22,7 +23,11 @@ set serveroutput on size unlimited format truncated
 @@lib/RunTest.sql ut_test/ut_test.TeardownExecutedAfterTest.sql
 @@lib/RunTest.sql ut_test/ut_test.TeardownProcedureNameInvalid.sql
 @@lib/RunTest.sql ut_test/ut_test.TeardownProcedureNameNull.sql
+@@lib/RunTest.sql ut_utils/ut_utils.test_result_to_char.RunsWithInvalidValues.sql
+@@lib/RunTest.sql ut_utils/ut_utils.test_result_to_char.RunsWithNullValue.sql
+@@lib/RunTest.sql ut_utils/ut_utils.test_result_to_char.Success.sql
 
+@@lib/RunTest.sql ut_metadata/ut_metadata.form_name.TrimStandaloneProgramName.sql
 --Global cleanup
 drop package ut_example_tests;
 
diff --git a/tests/ut_metadata/ut_metadata.form_name.TrimStandaloneProgramName.sql b/tests/ut_metadata/ut_metadata.form_name.TrimStandaloneProgramName.sql
@@ -0,0 +1,17 @@
+PROMPT Trims a name for standalone program
+
+--Arrange
+declare
+  l_expected varchar2(20) := 'some_procedure';
+  l_result varchar2(20);
+begin
+--Act
+  l_result :=  ut_metadata.form_name(NULL, ' '||l_expected||' ');
+--Assert
+  if l_result = l_expected then
+    :test_result := ut_utils.tr_success;
+  else
+    dbms_output.put_line('expected: '''||l_expected||''', got: '''||l_result||'''' );
+  end if;
+end;
+/
diff --git a/tests/ut_utils/ut_utils.test_result_to_char.RunsWithInvalidValues.sql b/tests/ut_utils/ut_utils.test_result_to_char.RunsWithInvalidValues.sql
@@ -0,0 +1,17 @@
+PROMPT Returns Unknown for invalid test result integer value
+
+--Arrange
+declare
+  l_expected varchar2(20) := 'Unknown(-1)';
+  l_result  varchar2(20);
+begin
+--Act
+  l_result :=  ut_utils.test_result_to_char(-1);
+--Assert
+  if l_result = l_expected then
+    :test_result := ut_utils.tr_success;
+  else
+    dbms_output.put_line('expected: '||l_expected||', got: '||l_result );
+  end if;
+end;
+/
diff --git a/tests/ut_utils/ut_utils.test_result_to_char.RunsWithNullValue.sql b/tests/ut_utils/ut_utils.test_result_to_char.RunsWithNullValue.sql
@@ -0,0 +1,17 @@
+PROMPT Converts Null test result integer value into 'Unknown(NULL)' text
+
+--Arrange
+declare
+  l_expected varchar2(20) := 'Unknown(NULL)';
+  l_result varchar2(20);
+begin
+--Act
+  l_result :=  ut_utils.test_result_to_char(NULL);
+--Assert
+  if l_result = l_expected then
+    :test_result := ut_utils.tr_success;
+  else
+    dbms_output.put_line('expected: '||l_expected||', got: '||l_result );
+  end if;
+end;
+/
diff --git a/tests/ut_utils/ut_utils.test_result_to_char.Success.sql b/tests/ut_utils/ut_utils.test_result_to_char.Success.sql
@@ -0,0 +1,17 @@
+PROMPT Converts success test result integer value into char
+
+--Arrange
+declare
+  l_expected varchar2(20) := ut_utils.tr_success_char;
+  l_result varchar2(20);
+begin
+--Act
+  l_result :=  ut_utils.test_result_to_char(ut_utils.tr_success);
+--Assert
+  if l_result = l_expected then
+    :test_result := ut_utils.tr_success;
+  else
+    dbms_output.put_line('expected: '||l_expected||', got: '||l_result );
+  end if;
+end;
+/
