Fixed tests failing due to NLS setting

Pazus · Pazus · commit 3ad5e02fd110 · 2016-10-01T13:01:43.000+03:00
diff --git a/tests/ut_assert/ut_assert.are_equal.scalar.FailsToExecuteWhenNullsPassedAsParameters.sql b/tests/ut_assert/ut_assert.are_equal.scalar.FailsToExecuteWhenNullsPassedAsParameters.sql
@@ -4,7 +4,7 @@ begin
   dbms_output.put_line('expected an exception but nothing was raised' );
 exception
   when others then
-    if sqlerrm like '%PLS-00307: too many declarations of ''ARE_EQUAL'' match this call%' then
+    if sqlerrm like '%PLS-00307: % ''ARE_EQUAL'' %' then
       :test_result := ut_utils.tr_success;
     else
       dbms_output.put_line( sqlerrm );
diff --git a/tests/ut_assert/ut_assert.are_equal.timestamp.GivesFailureForDifferentValues.sql b/tests/ut_assert/ut_assert.are_equal.timestamp.GivesFailureForDifferentValues.sql
@@ -1,3 +1,3 @@
 PROMPT Gives a failure when comparing different timestamp datatypes
 
-@@ut_assert/common/ut_assert.are_equal.scalar.common.sql 'timestamp(9)' 'to_Timestamp(''2016-09-06 22:36:11.123456789'',''yyyy-mm-dd hh24:mi:ss.xff'')' 'to_Timestamp(''2016-09-06 22:36:11.123456788'',''yyyy-mm-dd hh24:mi:ss.xff'')' 'ut_utils.tr_failure'
+@@ut_assert/common/ut_assert.are_equal.scalar.common.sql 'timestamp(9)' 'to_Timestamp(''2016-09-06 22:36:11.123456789'',''yyyy-mm-dd hh24:mi:ss.ff'')' 'to_Timestamp(''2016-09-06 22:36:11.123456788'',''yyyy-mm-dd hh24:mi:ss.ff'')' 'ut_utils.tr_failure'
diff --git a/tests/ut_assert/ut_assert.are_equal.timestamp.GivesSuccessForEqualValues.sql b/tests/ut_assert/ut_assert.are_equal.timestamp.GivesSuccessForEqualValues.sql
@@ -1,3 +1,3 @@
 PROMPT Gives a success when comparing equal timestamp datatypes
 
-@@ut_assert/common/ut_assert.are_equal.scalar.common.sql 'timestamp(9)' 'to_Timestamp(''2016-09-06 22:36:11.123456789'',''yyyy-mm-dd hh24:mi:ss.xff'')' 'to_Timestamp(''2016-09-06 22:36:11.123456789'',''yyyy-mm-dd hh24:mi:ss.xff'')' 'ut_utils.tr_success'
+@@ut_assert/common/ut_assert.are_equal.scalar.common.sql 'timestamp(9)' 'to_Timestamp(''2016-09-06 22:36:11.123456789'',''yyyy-mm-dd hh24:mi:ss.ff'')' 'to_Timestamp(''2016-09-06 22:36:11.123456789'',''yyyy-mm-dd hh24:mi:ss.ff'')' 'ut_utils.tr_success'
diff --git a/tests/ut_utils/ut_utils.to_string.Timestamp.sql b/tests/ut_utils/ut_utils.to_string.Timestamp.sql
@@ -3,9 +3,12 @@ PROMPT Returns a full string representation of a timestamp with maximum precissi
 --Arrange
 declare
   l_value    timestamp(9) := to_timestamp('2016-12-31 23:59:59.123456789', 'yyyy-mm-dd hh24:mi:ss.ff');
-  l_expected varchar2(100) := '2016-12-31 23:59:59.123456789';
+  l_expected varchar2(100);
   l_result   varchar2(100);
+  l_delimiter varchar2(1);
 begin
+  select substr(value, 1, 1) into l_delimiter from nls_session_parameters t where t.parameter = 'NLS_NUMERIC_CHARACTERS';
+  l_expected := '2016-12-31 23:59:59'||l_delimiter||'123456789';
 --Act
   l_result :=  ut_utils.to_String(l_value);
 --Assert
diff --git a/tests/ut_utils/ut_utils.to_string.verySmallNumber.sql b/tests/ut_utils/ut_utils.to_string.verySmallNumber.sql
@@ -5,9 +5,14 @@ declare
   l_value    number := 0.123456789012345678901234567890123456789;
   l_expected varchar2(100) := '.123456789012345678901234567890123456789';
   l_result   varchar2(100);
+  l_delimiter varchar2(1);
 begin
 --Act
+  select substr(value, 1, 1) into l_delimiter from nls_session_parameters t where t.parameter = 'NLS_NUMERIC_CHARACTERS';
+  l_expected := l_delimiter||'123456789012345678901234567890123456789';
+  
   l_result :=  ut_utils.to_String(l_value);
+  
 --Assert
   if l_result = l_expected then
     :test_result := ut_utils.tr_success;

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`PROMPT Gives a failure when comparing different timestamp datatypes`
`2`	`2`
`3`		`-@@ut_assert/common/ut_assert.are_equal.scalar.common.sql 'timestamp(9)' 'to_Timestamp(''2016-09-06 22:36:11.123456789'',''yyyy-mm-dd hh24:mi:ss.xff'')' 'to_Timestamp(''2016-09-06 22:36:11.123456788'',''yyyy-mm-dd hh24:mi:ss.xff'')' 'ut_utils.tr_failure'`
	`3`	`+@@ut_assert/common/ut_assert.are_equal.scalar.common.sql 'timestamp(9)' 'to_Timestamp(''2016-09-06 22:36:11.123456789'',''yyyy-mm-dd hh24:mi:ss.ff'')' 'to_Timestamp(''2016-09-06 22:36:11.123456788'',''yyyy-mm-dd hh24:mi:ss.ff'')' 'ut_utils.tr_failure'`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`PROMPT Gives a success when comparing equal timestamp datatypes`
`2`	`2`
`3`		`-@@ut_assert/common/ut_assert.are_equal.scalar.common.sql 'timestamp(9)' 'to_Timestamp(''2016-09-06 22:36:11.123456789'',''yyyy-mm-dd hh24:mi:ss.xff'')' 'to_Timestamp(''2016-09-06 22:36:11.123456789'',''yyyy-mm-dd hh24:mi:ss.xff'')' 'ut_utils.tr_success'`
	`3`	`+@@ut_assert/common/ut_assert.are_equal.scalar.common.sql 'timestamp(9)' 'to_Timestamp(''2016-09-06 22:36:11.123456789'',''yyyy-mm-dd hh24:mi:ss.ff'')' 'to_Timestamp(''2016-09-06 22:36:11.123456789'',''yyyy-mm-dd hh24:mi:ss.ff'')' 'ut_utils.tr_success'`