Fixed send_clob, added additional unit tests.

jgebal · jgebal · commit 4642f3c2dc90 · 2016-11-24T01:45:56.000Z
diff --git a/source/core/types/ut_output_dbms_output.tpb b/source/core/types/ut_output_dbms_output.tpb
@@ -18,9 +18,11 @@ create or replace type body ut_output_dbms_output as
   end;
 
   overriding member procedure send_clob(self in out nocopy ut_output_dbms_output, a_text clob) is
+    v_buffer ut_varchar2_list;
   begin
-    for i in (select column_value as text from table(ut_utils.clob_to_table(a_text)) ) loop
-      dbms_output.put_line(i.text);
+    v_buffer := ut_utils.clob_to_table(a_text);
+    for i in 1 .. v_buffer.count loop
+      dbms_output.put_line(v_buffer(i));
     end loop;
   end;
 
diff --git a/tests/RunAll.sql b/tests/RunAll.sql
@@ -170,6 +170,7 @@ create table ut$test_table (val varchar2(1));
 @@lib/RunTest.sql ut_output_dbms_output/ut_output_dbms_output.get_clob_lines.ReturnsSentLines.sql
 @@lib/RunTest.sql ut_output_dbms_output/ut_output_dbms_output.get_lines.RetunrsNoRowsWhenNoDataInBuffer.sql
 @@lib/RunTest.sql ut_output_dbms_output/ut_output_dbms_output.get_lines.ReturnsSentLines.sql
+@@lib/RunTest.sql ut_output_dbms_output/ut_output_dbms_output.send_clob.SendsAClobIntoPipe.sql
 --Global cleanup
 drop package ut_example_tests;
 drop procedure check_annotation_parsing;
diff --git a/tests/ut_output_dbms_output/ut_output_dbms_output.get_clob_lines.ReturnsSentLines.sql b/tests/ut_output_dbms_output/ut_output_dbms_output.get_clob_lines.ReturnsSentLines.sql
@@ -4,7 +4,7 @@ declare
   l_output   ut_output_dbms_output := ut_output_dbms_output();
   l_expected clob;
 begin
-  l_expected := lpad('a',32000,'a');
+  l_expected := lpad('a',32767,'a');
   --Act - open the pipe
   l_output.send_clob(l_expected);
   l_output.send_clob(l_expected);
diff --git a/tests/ut_output_dbms_output/ut_output_dbms_output.send_clob.SendsAClobIntoPipe.sql b/tests/ut_output_dbms_output/ut_output_dbms_output.send_clob.SendsAClobIntoPipe.sql
@@ -0,0 +1,47 @@
+PROMPT ut_output_dbms_output.send_clob Sends a clob Into Pipe in a separate session and recieves it back cut into 4000 char pieces
+
+declare
+  l_message_lenght integer := 98765;
+  l_output      ut_output_dbms_output := ut_output_dbms_output();
+  l_text_lenght  integer;
+  l_chunk_lenght integer;
+begin
+  --Arrange - send clob to dbms_output
+  declare
+    l_expected_length  integer := l_message_lenght;
+    l_max_varchar2_len integer := 32767;
+    l_loops            integer := floor(l_expected_length / l_max_varchar2_len);
+    l_string           varchar2(32767);
+    l_output           ut_output_dbms_output := ut_output_dbms_output();
+    l_lob clob;
+  begin
+    dbms_lob.createtemporary(l_lob, true);
+    for i in 1 .. l_loops loop
+      l_string := lpad('a', l_max_varchar2_len, 'a');
+      dbms_lob.writeappend( l_lob, length(l_string), l_string );
+    end loop;
+    if l_loops*l_max_varchar2_len < l_expected_length then
+      l_string := lpad('a', mod(l_expected_length, l_max_varchar2_len), 'a');
+      dbms_lob.writeappend( l_lob, length(l_string), l_string );
+    end if;
+    l_output.send_clob(l_lob);
+  end;
+
+
+  --Act - get clob as lines from dbms_output
+  select sum(nvl(length(column_value),0)), max(length(column_value))
+    into l_text_lenght, l_chunk_lenght
+    from table( l_output.get_lines(NULL) );
+  --Assert - check that the length of text recieved is same as lenght of text sent
+  if l_text_lenght = l_message_lenght and l_chunk_lenght = 4000 then
+    :test_result := ut_utils.tr_success;
+  elsif not nvl(l_chunk_lenght,0) = 4000 then
+    dbms_output.put_line('Expected chunk length of 4000 but got'||l_chunk_lenght);
+  else
+    dbms_output.put_line('Expected '||l_message_lenght||' characters, got '||l_text_lenght);
+  end if;
+end;
+/
+
+
+
