Handled (ignored) exception savepoint never established

Pazus · Pazus · commit 56d72c226e75 · 2017-01-30T08:44:36.000+03:00
Add validation test
diff --git a/source/core/types/ut_suite_item.tpb b/source/core/types/ut_suite_item.tpb
@@ -36,10 +36,15 @@ create or replace type body ut_suite_item as
   end;
 
   member procedure rollback_to_savepoint(self in ut_suite_item, a_savepoint varchar2) is
+    ex_savepoint_not_exists exception;
+    pragma exception_init(ex_savepoint_not_exists, -1086);
   begin
     if self.rollback_type = ut_utils.gc_rollback_auto and a_savepoint is not null then
       execute immediate 'rollback to ' || a_savepoint;
     end if;
+  exception
+    when ex_savepoint_not_exists then
+      null;
   end;
 
   member function execution_time return number is
diff --git a/tests/RunAll.sql b/tests/RunAll.sql
@@ -90,6 +90,7 @@ create table ut$test_table (val varchar2(1));
 @@lib/RunTest.sql ut_test/ut_test.TeardownExecutedAfterTest.sql
 @@lib/RunTest.sql ut_test/ut_test.TeardownProcedureNameInvalid.sql
 @@lib/RunTest.sql ut_test/ut_test.TeardownProcedureNameNull.sql
+@@lib/RunTest.sql ut_test/ut_test.IgnoreTollbackToSavepointException.sql
 @@lib/RunTest.sql ut_test_suite/ut_test_suite.IgnoreFlagSkipSuite.sql
 @@lib/RunTest.sql ut_test_suite/ut_test_suite.Rollback_type.Auto.sql
 @@lib/RunTest.sql ut_test_suite/ut_test_suite.Rollback_type.AutoOnFailure.sql
diff --git a/tests/helpers/ut_example_tests.pkb b/tests/helpers/ut_example_tests.pkb
@@ -19,6 +19,12 @@ as
     g_char := 'a';
     ut.expect(1,'Test 1 Should Pass').to_equal(1);
  end;
+ 
+ procedure ut_commit_test 
+ is
+ begin
+   commit;
+ end;
 
 end;
 /
diff --git a/tests/helpers/ut_example_tests.pks b/tests/helpers/ut_example_tests.pks
@@ -5,5 +5,6 @@ as
  procedure setup;
  procedure teardown;
  procedure ut_passing_test;
+ procedure ut_commit_test;
 end;
 /
diff --git a/tests/ut_test/ut_test.IgnoreTollbackToSavepointException.sql b/tests/ut_test/ut_test.IgnoreTollbackToSavepointException.sql
@@ -0,0 +1,17 @@
+PROMPT Checks that rollback exception doesn't make run to fail
+
+--Arrange
+declare
+	simple_test ut_test := ut_test(a_object_name => 'ut_example_tests', a_name => 'ut_commit_test',a_rollback_type => ut_utils.gc_rollback_auto);
+	listener ut_event_listener := ut_event_listener(ut_reporters());
+begin
+--Act
+	simple_test.do_execute(listener);
+--Assert
+	if simple_test.result = ut_utils.tr_success then
+    :test_result := ut_utils.tr_success;
+	else
+		dbms_output.put_line('simple_test.result = '||ut_utils.test_result_to_char(simple_test.result));
+	end if;
+end;
+/

Original file line number	Diff line number	Diff line change
`@@ -5,5 +5,6 @@ as`
`5`	`5`	`procedure setup;`
`6`	`6`	`procedure teardown;`
`7`	`7`	`procedure ut_passing_test;`
	`8`	`+ procedure ut_commit_test;`
`8`	`9`	`end;`
`9`	`10`	`/`