Merge pull request #296 from Pazus/fix_wrapped_package

jgebal · web-flow · commit 5aa1e17e148e · 2017-05-02T00:20:16.000+01:00
Fixed wrapped package annotation scan
diff --git a/source/core/ut_annotations.pkb b/source/core/ut_annotations.pkb
@@ -337,12 +337,19 @@ create or replace package body ut_annotations as
 
   function get_package_annotations(a_owner_name varchar2, a_name varchar2) return typ_annotated_package is
     l_source clob;
+    ex_package_is_wrapped exception;
+    pragma exception_init(ex_package_is_wrapped, -24241);
   begin
 
     -- TODO: Add cache of annotations. Cache invalidation should be based on DDL timestamp.
     -- Cache garbage collection should be executed once in a while to remove annotations cache for packages that were dropped.
-
-    l_source := ut_metadata.get_package_spec_source(a_owner_name, a_name);
+    
+    begin
+      l_source := ut_metadata.get_package_spec_source(a_owner_name, a_name);
+    exception
+      when ex_package_is_wrapped then
+        null;
+    end;
 
     if l_source is null or sys.dbms_lob.getlength(l_source)=0 then
       return null;
diff --git a/tests/RunAll.sql b/tests/RunAll.sql
@@ -31,6 +31,7 @@ create table ut$test_table (val varchar2(1));
 exec ut_coverage.coverage_start_develop();
 @@lib/mystats/mystats start
 
+@@lib/RunTest.sql ut_annotations/ut_annotations.parse_package_annotations.IgnoreWrappedPackageAndDoesNotRaiseException.sql
 @@lib/RunTest.sql ut_annotations/ut_annotations.parse_package_annotations.ParseAnnotationMixedWithWrongBeforeProcedure.sql
 @@lib/RunTest.sql ut_annotations/ut_annotations.parse_package_annotations.ParseAnnotationNotBeforeProcedure.sql
 @@lib/RunTest.sql ut_annotations/ut_annotations.parse_package_annotations.ParseComplexPackage.sql
diff --git a/tests/ut_annotations/ut_annotations.parse_package_annotations.IgnoreWrappedPackageAndDoesNotRaiseException.sql b/tests/ut_annotations/ut_annotations.parse_package_annotations.IgnoreWrappedPackageAndDoesNotRaiseException.sql
@@ -0,0 +1,22 @@
+begin
+  DBMS_DDL.CREATE_WRAPPED(
+q'[
+CREATE OR REPLACE PACKAGE tst_wrapped_pck IS
+  PROCEDURE dummy;
+END;
+]'
+  );
+end;
+/
+
+declare
+  l_pck_annotation ut_annotations.typ_annotated_package;
+begin
+  l_pck_annotation := ut_annotations.get_package_annotations(user, 'TST_WRAPPED_PCK');
+  if l_pck_annotation.procedure_annotations.count = 0 and l_pck_annotation.package_annotations.count = 0 then
+    :test_result := ut_utils.tr_success;
+  end if;
+end;
+/
+
+drop package tst_wrapped_pck;
