Fixed storage for clob in output bugger table - make it inline.

jgebal · jgebal · commit 7bae9ff5f67d · 2019-03-30T20:58:55.000Z
Changed how delete from output buffer table is handled - use ROWID.
Increased fetch size from 100 to 3000 rows for output buffer.
diff --git a/source/core/output_buffers/ut_output_buffer_tmp.sql b/source/core/output_buffers/ut_output_buffer_tmp.sql
@@ -32,14 +32,15 @@ begin
          is_finished = 0 and (text is not null or item_type is not null )
       or is_finished = 1 and text is null and item_type is null ),
   constraint ut_output_buffer_fk1 foreign key (output_id) references ut_output_buffer_info_tmp$(output_id)
-) organization index overflow nologging initrans 100 ';
+) nologging initrans 100
+';
   begin
     execute immediate
-      v_table_sql || 'lob(text) store as securefile ut_output_text(retention none)';
+      v_table_sql || 'lob(text) store as securefile ut_output_text(retention none enable storage in row)';
   exception
     when e_non_assm then
       execute immediate
-        v_table_sql || 'lob(text) store as basicfile ut_output_text(pctversion 0)';
+        v_table_sql || 'lob(text) store as basicfile ut_output_text(pctversion 0 enable storage in row)';
 
   end;
 end;
diff --git a/source/core/output_buffers/ut_output_table_buffer.tpb b/source/core/output_buffers/ut_output_table_buffer.tpb
@@ -78,8 +78,9 @@ create or replace type body ut_output_table_buffer is
   end;
 
   overriding member function get_lines(a_initial_timeout natural := null, a_timeout_sec natural := null) return ut_output_data_rows pipelined is
+    type t_rowid_tab     is table of urowid;
+    l_message_rowids     t_rowid_tab;
     l_buffer_data        ut_output_data_rows;
-    l_message_ids        ut_integer_list;
     l_finished_flags     ut_integer_list;
     l_already_waited_for number(10,2) := 0;
     l_finished           boolean := false;
@@ -90,14 +91,14 @@ create or replace type body ut_output_table_buffer is
     lc_long_sleep_time   constant number(1) := 1;     --sleep for 1 s when waiting long
     lc_long_wait_time    constant number(1) := 1;     --waiting more than 1 sec
     l_sleep_time         number(2,1) := lc_short_sleep_time;
-    lc_bulk_limit        constant integer := 100;
+    lc_bulk_limit        constant integer := 3000;
 
-    procedure remove_read_data(a_message_ids ut_integer_list) is
+    procedure remove_read_data(a_message_rowids t_rowid_tab) is
       pragma autonomous_transaction;
     begin
-      delete from ut_output_buffer_tmp a
-       where a.output_id = self.output_id
-         and a.message_id in (select column_value from table(a_message_ids));
+      forall i in 1 .. a_message_rowids.count
+        delete from ut_output_buffer_tmp a
+         where rowid = a_message_rowids(i);
       commit;
     end;
 
@@ -112,13 +113,13 @@ create or replace type body ut_output_table_buffer is
     begin
     while not l_finished loop
       with ordered_buffer as (
-        select a.message_id, ut_output_data_row(a.text, a.item_type), is_finished
+        select a.rowid, ut_output_data_row(a.text, a.item_type), is_finished
           from ut_output_buffer_tmp a
          where a.output_id = self.output_id
          order by a.message_id
       )
       select b.*
-        bulk collect into l_message_ids, l_buffer_data, l_finished_flags
+        bulk collect into l_message_rowids, l_buffer_data, l_finished_flags
         from ordered_buffer b
        where rownum <= lc_bulk_limit;
 
@@ -147,7 +148,7 @@ create or replace type body ut_output_table_buffer is
             exit;
           end if;
         end loop;
-        remove_read_data(l_message_ids);
+        remove_read_data(l_message_rowids);
       end if;
       if l_finished or l_already_waited_for >= l_wait_for then
         remove_buffer_info();
diff --git a/source/install.sql b/source/install.sql
@@ -194,7 +194,6 @@ prompt Installing DBMSPLSQL Tables objects into &&ut3_owner schema
 @@install_component.sql 'expectations/data_values/ut_cursor_column.tps'
 @@install_component.sql 'expectations/data_values/ut_cursor_column_tab.tps'
 @@install_component.sql 'expectations/data_values/ut_cursor_details.tps'
-@@install_component.sql 'expectations/data_values/ut_data_value_anydata.tps'
 @@install_component.sql 'expectations/data_values/ut_data_value_blob.tps'
 @@install_component.sql 'expectations/data_values/ut_data_value_boolean.tps'
 @@install_component.sql 'expectations/data_values/ut_data_value_clob.tps'
