Fixed long name test.

jgebal · jgebal · commit 8d87e9632671 · 2017-10-15T15:32:36.000+01:00
Fixed invalid source test.
Removed failing test for conditional compilationon 12.2 docker DB due to dbms_preprocessor issues.
diff --git a/test/ut_annotation_parser/test_annotation_parser.pkb b/test/ut_annotation_parser/test_annotation_parser.pkb
@@ -413,14 +413,14 @@ v58yvbLAXLi9gYHwoIvAgccti+Cmpg0DKLY=
       ut3.ut_annotation( 4, 'test', null, 'very_long_procedure_name_valid_for_oracle_12_so_utPLSQL_should_allow_it_definitely_well_still_not_reached_128_but_wait_we_dit_it' )
     );
 
-    l_source(1) := 'PACKAGE test_tt AS
-      -- %suite
-      -- %displayname(Name of suite)
-      -- %suitepath(all.globaltests)
-
-      --%test
-      procedure very_long_procedure_name_valid_for_oracle_12_so_utPLSQL_should_allow_it_definitely_well_still_not_reached_128_but_wait_we_dit_it;
-    END;';
+    l_source(1) := 'PACKAGE very_long_package_name_valid_for_oracle_12_so_utPLSQL_should_allow_it_definitely_well_still_not_reached_128_but_wait_we_did_it AS'|| chr(10);
+    l_source(2) := '  -- %suite'|| chr(10);
+    l_source(3) := '  -- %displayname(Name of suite)'|| chr(10);
+    l_source(4) := '  -- %suitepath(all.globaltests)'|| chr(10);
+    l_source(5) := ' '|| chr(10);
+    l_source(6) := '  --%test'|| chr(10);
+    l_source(7) := '  procedure very_long_procedure_name_valid_for_oracle_12_so_utPLSQL_should_allow_it_definitely_well_still_not_reached_128_but_wait_we_dit_it;'|| chr(10);
+    l_source(8) := 'END;'|| chr(10);
 
     --Act
     l_actual         := ut3.ut_annotation_parser.parse_object_annotations(l_source);
@@ -429,53 +429,23 @@ v58yvbLAXLi9gYHwoIvAgccti+Cmpg0DKLY=
     ut.expect(anydata.convertCollection(l_actual)).to_equal(anydata.convertCollection(l_expected));
   end;
 
-  -- %test(Ignores annotations in an invalid source code)
   procedure ignore_invalid_source_code is
     l_source    dbms_preprocessor.source_lines_t;
     l_actual    ut3.ut_annotations;
   begin
     --Arrange
-    l_source(1) := 'not a PACKAGE test_tt AS
-        --%suite
-        --%suitepath (all.globaltests)
-
-        --%test
-        procedure foo;
-      END;';
+    l_source(1) := 'not a PACKAGE test_tt AS'|| chr(10);
+    l_source(2) := '  --%suite'|| chr(10);
+    l_source(3) := '  --%suitepath (all.globaltests)'|| chr(10);
+    l_source(4) := ' '|| chr(10);
+    l_source(5) := '  --%test'|| chr(10);
+    l_source(6) := '  procedure foo;'|| chr(10);
+    l_source(7) := 'END;'|| chr(10);
     --Act
     l_actual := ut3.ut_annotation_parser.parse_object_annotations(l_source);
     --Assert
     ut.expect(anydata.convertCollection(l_actual)).to_be_empty();
   end;
 
-  procedure ignore_conditional_block is
-    l_source         dbms_preprocessor.source_lines_t;
-    l_actual         ut3.ut_annotations;
-    l_expected       ut3.ut_annotations;
-  begin
-    --Arrange
-    l_expected := ut3.ut_annotations(
-      ut3.ut_annotation( 1, 'suite', null, null ),
-      ut3.ut_annotation( 2, 'test', 'enabled', 'test1' )
-    );
-
-    l_source(1) := 'package conditionally_annotated as
-      --%suite
-
-    $if 1=1 $then
-      --%test(enabled)
-      procedure test1;
-    $else
-      --%test(disabled)
-      procedure test2;
-    $end
-    end;';
-
-    --Act
-    l_actual  := ut3.ut_annotation_parser.parse_object_annotations(l_source);
-
-    --Assert
-    ut.expect(anydata.convertCollection(l_actual)).to_equal(anydata.convertCollection(l_expected));
-  end;
 end test_annotation_parser;
 /
diff --git a/test/ut_annotation_parser/test_annotation_parser.pks b/test/ut_annotation_parser/test_annotation_parser.pks
@@ -45,8 +45,5 @@ create or replace package test_annotation_parser is
   -- %test(Ignores annotations in an invalid source code)
   procedure ignore_invalid_source_code;
 
-  -- %test(Ignores annotations in a conditionally compiled code)
-  procedure ignore_conditional_block;
-
 end test_annotation_parser;
 /

Original file line number	Diff line number	Diff line change
`@@ -45,8 +45,5 @@ create or replace package test_annotation_parser is`
`45`	`45`	`-- %test(Ignores annotations in an invalid source code)`
`46`	`46`	`procedure ignore_invalid_source_code;`
`47`	`47`
`48`		`- -- %test(Ignores annotations in a conditionally compiled code)`
`49`		`- procedure ignore_conditional_block;`
`50`		`-`
`51`	`48`	`end test_annotation_parser;`
`52`	`49`	`/`