Merge pull request #948 from utPLSQL/fix/json_11_2_comp

jgebal · web-flow · commit 99cf9fcc16d6 · 2019-06-20T07:59:05.000+01:00
Fix issue for Oracle 11.2 where the local collection is used SQL
diff --git a/source/expectations/data_values/ut_compound_data_helper.pkb b/source/expectations/data_values/ut_compound_data_helper.pkb
@@ -724,12 +724,13 @@ create or replace package body ut_compound_data_helper is
     return l_diffs.count;
   end;
   
-  function get_json_diffs_type(a_diffs_all tt_json_diff_tab) return tt_json_diff_type_tab is
+  function get_json_diffs_type(a_diff_id raw) return tt_json_diff_type_tab is
     l_diffs_summary tt_json_diff_type_tab := tt_json_diff_type_tab();
   begin
     select d.difference_type,count(1) 
     bulk collect into l_diffs_summary
-    from table(a_diffs_all) d
+    from ut_json_data_diff_tmp d
+    where diff_id = a_diff_id
     group by d.difference_type;
     
     return l_diffs_summary;
diff --git a/source/expectations/data_values/ut_compound_data_helper.pks b/source/expectations/data_values/ut_compound_data_helper.pks
@@ -134,7 +134,7 @@ create or replace package ut_compound_data_helper authid definer is
   function get_json_diffs_tmp(a_diff_id raw) return tt_json_diff_tab;
 
   
-  function get_json_diffs_type(a_diffs_all tt_json_diff_tab) return tt_json_diff_type_tab;
+  function get_json_diffs_type(a_diff_id raw) return tt_json_diff_type_tab;
   
 end;
 /
diff --git a/source/expectations/data_values/ut_data_value_json.tpb b/source/expectations/data_values/ut_data_value_json.tpb
@@ -58,8 +58,8 @@ create or replace type body ut_data_value_json as
     l_diffs             ut_compound_data_helper.tt_json_diff_tab;
     l_message           varchar2(32767);
     
-    function get_diff_by_type(a_diff ut_compound_data_helper.tt_json_diff_tab) return clob is
-      l_diff_summary  ut_compound_data_helper.tt_json_diff_type_tab := ut_compound_data_helper.get_json_diffs_type(a_diff);
+    function get_diff_by_type(a_diff_id raw) return clob is
+      l_diff_summary  ut_compound_data_helper.tt_json_diff_type_tab := ut_compound_data_helper.get_json_diffs_type(a_diff_id);
       l_message_list  ut_varchar2_list := ut_varchar2_list();
     begin
       for i in 1..l_diff_summary.count loop
@@ -103,7 +103,7 @@ create or replace type body ut_data_value_json as
       l_message := ' '||l_diffs.count|| ' differences found' ||
         case when l_diffs.count > c_max_rows then ', showing first '|| c_max_rows else null end||chr(10);
       ut_utils.append_to_clob( l_result, l_message );
-      l_message := get_diff_by_type(l_diffs)||chr(10);
+      l_message := get_diff_by_type(l_diff_id)||chr(10);
       ut_utils.append_to_clob( l_result, l_message );
 
       for i in 1 .. least( c_max_rows, l_diffs.count ) loop

Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,7 @@ create or replace package ut_compound_data_helper authid definer is`
`134`	`134`	`function get_json_diffs_tmp(a_diff_id raw) return tt_json_diff_tab;`
`135`	`135`
`136`	`136`
`137`		`- function get_json_diffs_type(a_diffs_all tt_json_diff_tab) return tt_json_diff_type_tab;`
	`137`	`+ function get_json_diffs_type(a_diff_id raw) return tt_json_diff_type_tab;`
`138`	`138`
`139`	`139`	`end;`
`140`	`140`	`/`