Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit a0462a7

Browse files
jgebaljgebal
committed
Fixing tests after schema rename.
Make sure SONAR runs, even if build fails.
1 parent 1d86276 commit a0462a7

4 files changed

Lines changed: 18 additions & 18 deletions

File tree

‎.github/workflows/build.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ jobs:
193193

194194
- name: SonarCloud Scan
195195
id: sonar
196-
if: ${{ matrix.db_version_name == '21XE' }}
196+
if: ${{ always() && matrix.db_version_name == '21XE' }}
197197
uses: SonarSource/sonarcloud-github-action@master
198198
env:
199199
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any

‎test/ut3_user/api/test_ut_run.pkb‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -625,7 +625,7 @@ Failures:%
625625
begin
626626
execute immediate q'[select count(1) from all_objects o where o.owner = :object_owner and o.object_type = 'PACKAGE'
627627
and o.status = 'INVALID' and o.object_name= :object_name]' into l_is_invalid
628-
using 'UT3$USER#','INVALID_PCKAG_THAT_REVALIDATES';
628+
using 'UT3_USER','INVALID_PCKAG_THAT_REVALIDATES';
629629

630630
select * bulk collect into l_results from table(ut3_develop.ut.run('invalid_pckag_that_revalidates'));
631631

‎test/ut3_user/api/test_ut_runner.pkb‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,7 @@ end;';
339339
'dummy_test_package.some_dummy_test_procedure' path, 0 disabled_flag, null disabled_reason,'testtag1,testtag2' tags
340340
from dual;
341341
--Act
342-
open l_actual for select * from table(ut3_develop.ut_runner.get_suites_info('UT3$USER#','DUMMY_TEST_PACKAGE'));
342+
open l_actual for select * from table(ut3_develop.ut_runner.get_suites_info('UT3_USER','DUMMY_TEST_PACKAGE'));
343343
--Assert
344344
ut.expect(l_actual).to_equal(l_expected);
345345
end;
@@ -571,47 +571,47 @@ end;';
571571
begin
572572
ut.expect(
573573
ut3_develop.ut_runner.is_test(
574-
a_owner => 'UT3$USER#',
574+
a_owner => 'UT3_USER',
575575
a_package_name => 'DUMMY_TEST_PACKAGE',
576576
a_procedure_name => 'SOME_DUMMY_TEST_PROCEDURE'
577577
)
578578
).to_be_true();
579-
ut.expect( ut3_develop.ut_runner.is_test( 'ut3$user#','dummy_test_package','some_dummy_test_procedure' ) ).to_be_true();
579+
ut.expect( ut3_develop.ut_runner.is_test( 'ut3_user','dummy_test_package','some_dummy_test_procedure' ) ).to_be_true();
580580
end;
581581

582582
procedure is_test_false is
583583
begin
584-
ut.expect( ut3_develop.ut_runner.is_test( 'UT3$USER#','DUMMY_TEST_PACKAGE', 'BAD' ) ).to_be_false();
585-
ut.expect( ut3_develop.ut_runner.is_test( 'UT3$USER#','BAD_TEST_PACKAGE', 'some_dummy_test_procedure' ) ).to_be_false();
586-
ut.expect( ut3_develop.ut_runner.is_test( 'UT3$USER#','DUMMY_TEST_PACKAGE', null ) ).to_be_false();
587-
ut.expect( ut3_develop.ut_runner.is_test( 'UT3$USER#',null,'some_dummy_test_procedure' ) ).to_be_false();
584+
ut.expect( ut3_develop.ut_runner.is_test( 'UT3_USER','DUMMY_TEST_PACKAGE', 'BAD' ) ).to_be_false();
585+
ut.expect( ut3_develop.ut_runner.is_test( 'UT3_USER','BAD_TEST_PACKAGE', 'some_dummy_test_procedure' ) ).to_be_false();
586+
ut.expect( ut3_develop.ut_runner.is_test( 'UT3_USER','DUMMY_TEST_PACKAGE', null ) ).to_be_false();
587+
ut.expect( ut3_develop.ut_runner.is_test( 'UT3_USER',null,'some_dummy_test_procedure' ) ).to_be_false();
588588
ut.expect( ut3_develop.ut_runner.is_test( null,'DUMMY_TEST_PACKAGE','some_dummy_test_procedure' ) ).to_be_false();
589589
end;
590590

591591
procedure is_suite_true is
592592
begin
593593
ut.expect(
594594
ut3_develop.ut_runner.is_suite(
595-
a_owner => 'UT3$USER#',
595+
a_owner => 'UT3_USER',
596596
a_package_name => 'DUMMY_TEST_PACKAGE'
597597
)
598598
).to_be_true();
599599

600-
ut.expect( ut3_develop.ut_runner.is_suite( 'ut3$user#','dummy_test_package' ) ).to_be_true();
600+
ut.expect( ut3_develop.ut_runner.is_suite( 'ut3_user','dummy_test_package' ) ).to_be_true();
601601
end;
602602

603603
procedure is_suite_false is
604604
begin
605-
ut.expect( ut3_develop.ut_runner.is_suite( 'UT3$USER#','BAD' ) ).to_be_false();
606-
ut.expect( ut3_develop.ut_runner.is_suite( 'UT3$USER#', null ) ).to_be_false();
605+
ut.expect( ut3_develop.ut_runner.is_suite( 'UT3_USER','BAD' ) ).to_be_false();
606+
ut.expect( ut3_develop.ut_runner.is_suite( 'UT3_USER', null ) ).to_be_false();
607607
ut.expect( ut3_develop.ut_runner.is_suite( null,'DUMMY_TEST_PACKAGE' ) ).to_be_false();
608-
ut.expect( ut3_develop.ut_runner.is_suite( 'UT3$USER#','bad_test_package' ) ).to_be_false();
608+
ut.expect( ut3_develop.ut_runner.is_suite( 'UT3_USER','bad_test_package' ) ).to_be_false();
609609
end;
610610

611611
procedure has_suites_true is
612612
begin
613-
ut.expect( ut3_develop.ut_runner.has_suites( a_owner => 'UT3$USER#' ) ).to_be_true();
614-
ut.expect( ut3_develop.ut_runner.has_suites( 'ut3$user#' ) ).to_be_true();
613+
ut.expect( ut3_develop.ut_runner.has_suites( a_owner => 'UT3_USER' ) ).to_be_true();
614+
ut.expect( ut3_develop.ut_runner.has_suites( 'ut3_user' ) ).to_be_true();
615615
end;
616616

617617
procedure has_suites_false is

‎test/ut3_user/expectations/test_expectations_cursor.pkb‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2507,7 +2507,7 @@ Diff:%
25072507
begin
25082508
l_exp_message :='ORA-20218: SQL exception thrown when fetching data from cursor:
25092509
ORA-01476: divisor is equal to zero
2510-
at "UT3$USER#.TEST_EXPECTATIONS_CURSOR%", line % ut3_develop.ut.expect(l_actual).to_equal(l_expected);%
2510+
at "UT3_USER.TEST_EXPECTATIONS_CURSOR%", line % ut3_develop.ut.expect(l_actual).to_equal(l_expected);%
25112511
Check the query and data for errors.';
25122512

25132513
open l_actual for
@@ -2532,7 +2532,7 @@ Check the query and data for errors.';
25322532

25332533
l_exp_message :='ORA-20218: SQL exception thrown when fetching data from cursor:
25342534
ORA-01476: divisor is equal to zero
2535-
at "UT3$USER#.TEST_EXPECTATIONS_CURSOR%", line % ut3_develop.ut.expect(l_actual).to_equal(l_expected);%
2535+
at "UT3_USER.TEST_EXPECTATIONS_CURSOR%", line % ut3_develop.ut.expect(l_actual).to_equal(l_expected);%
25362536
Check the query and data for errors.';
25372537

25382538
open l_expected for

0 commit comments

Comments
 (0)