Added tests for clob_to_table, fixed one small issue found.

jgebal · jgebal · commit aa7c711a4ba5 · 2016-11-18T01:59:13.000Z
diff --git a/source/core/ut_utils.pkb b/source/core/ut_utils.pkb
@@ -132,7 +132,7 @@ create or replace package body ut_utils is
     l_result             ut_output_varchar2_list := ut_output_varchar2_list();
     l_delimiter_position integer;
   begin
-    if a_string is not null then
+    if a_string is not null and a_delimiter is not null then
       l_length := length(a_string);
       loop
         l_result.extend;
diff --git a/source/core/ut_utils.pks b/source/core/ut_utils.pks
@@ -122,7 +122,7 @@ create or replace package ut_utils authid definer is
    Splits a given string into table of string by delimiter.
    The delimiter gets removed.
    If null passed as any of the parameters, empty table is returned.
-   If no occurence of a_delimiter found in a_text then text is returned as a single row of the table.
+   If split text is longer than a_max_amount it gets split into pieces of a_max_amount.
    If no text between delimiters found then an empty row is returned, example:
      string_to_table( 'a,,b', ',' ) gives table ut_output_varchar2_list( 'a', null, 'b' );
   */
diff --git a/tests/RunAll.sql b/tests/RunAll.sql
@@ -137,6 +137,7 @@ create table ut$test_table (val varchar2(1));
 @@lib/RunTest.sql ut_test_suite/ut_test_suite.Rollback_type.AutoOnFailure.sql
 @@lib/RunTest.sql ut_test_suite/ut_test_suite.Rollback_type.Manual.sql
 @@lib/RunTest.sql ut_test_suite/ut_test_suite.Rollback_type.ManualOnFailure.sql
+@@lib/RunTest.sql ut_utils/ut_utils.clob_to_table.sql
 @@lib/RunTest.sql ut_utils/ut_utils.test_result_to_char.RunsWithInvalidValues.sql
 @@lib/RunTest.sql ut_utils/ut_utils.test_result_to_char.RunsWithNullValue.sql
 @@lib/RunTest.sql ut_utils/ut_utils.test_result_to_char.Success.sql
diff --git a/tests/ut_utils/common/ut_utils.clob_to_table.sql b/tests/ut_utils/common/ut_utils.clob_to_table.sql
@@ -0,0 +1,27 @@
+--Arrange
+declare
+  l_clob       clob := '&1';
+  l_delimiter  varchar2(1) := '&2';
+  l_expected   ut_output_varchar2_list := &3;
+  l_result     ut_output_varchar2_list;
+  l_limit      integer := &4;
+  l_result_str varchar2(32767);
+begin
+--Act
+  select column_value
+    bulk collect into l_result
+    from table(ut_utils.clob_to_table(l_clob, l_delimiter, l_limit));
+  for i in 1 .. l_result.count loop
+    if i = l_result.count then
+       l_delimiter := null;
+    end if;
+    l_result_str := ''''||l_result(i)||l_delimiter||'''';
+  end loop;
+--Assert
+  if l_result = l_expected then
+    :test_result := ut_utils.tr_success;
+  else
+    dbms_output.put_line('expected: '||q'[&3]'||', got: ut_output_varchar2_list('||l_result_str||')' );
+  end if;
+end;
+/
diff --git a/tests/ut_utils/ut_utils.clob_to_table.sql b/tests/ut_utils/ut_utils.clob_to_table.sql
@@ -0,0 +1,14 @@
+PROMPT Splits a given string into table of string by delimiter
+@@ut_utils/common/ut_utils.clob_to_table.sql 'a,b,c,d' ',' ut_output_varchar2_list('a','b','c','d') 1000
+
+PROMPT If null passed as any of the parameters, empty table is returned.
+@@ut_utils/common/ut_utils.clob_to_table.sql '' ',' ut_output_varchar2_list() 1000
+@@ut_utils/common/ut_utils.clob_to_table.sql '1,b,c,d' '' ut_output_varchar2_list() 1000
+
+PROMPT If split text is longer than a_max_amount it gets split into pieces of a_max_amount
+@@ut_utils/common/ut_utils.clob_to_table.sql 'abcdefg,hijk,axa,a' ',' ut_output_varchar2_list('abc','def','g','hij','k','axa','a') 3
+
+PROMPT If no text between delimiters found then an empty row is returned
+@@ut_utils/common/ut_utils.clob_to_table.sql ',a,,c,d,' ',' ut_output_varchar2_list('','a','','c','d','') 1000
+
+
