Merge branch 'develop' of github.com:utPLSQL/utPLSQL into feature/tags

lwasylow · lwasylow · commit b636830b9e15 · 2019-04-28T16:19:57.000+01:00
diff --git a/.travis.yml b/.travis.yml
@@ -56,6 +56,7 @@ env:
     - ORACLE_VERSION="${DOCKER_TAG_12C:-12c-r1-se2-small}"  CONNECTION_STR='127.0.0.1:1521/ORCLCDB'  DOCKER_OPTIONS="-v /dev/pdbs:/opt/oracle/oradata/pdbs"
     - ORACLE_VERSION="${DOCKER_TAG_12C2:-12c-r2-se2-small}" CONNECTION_STR='127.0.0.1:1521/ORCLCDB'  DOCKER_OPTIONS="-v /dev/pdbs:/opt/oracle/oradata/pdbs"
     - ORACLE_VERSION="${DOCKER_TAG_18:-18c-se2-small}"      CONNECTION_STR='127.0.0.1:1521/ORCLCDB'  DOCKER_OPTIONS="-v /dev/pdbs:/opt/oracle/oradata/pdbs"
+    - ORACLE_VERSION="${DOCKER_TAG_19:-19c-se2-small}"      CONNECTION_STR='127.0.0.1:1521/ORCLCDB'  DOCKER_OPTIONS="-v /dev/pdbs:/opt/oracle/oradata/pdbs"
 
 cache:
   pip: true
diff --git a/docs/about/authors.md b/docs/about/authors.md
@@ -1,4 +1,4 @@
-![version](https://img.shields.io/badge/version-v3.1.7.2886--develop-blue.svg)
+![version](https://img.shields.io/badge/version-v3.1.7.2904--develop-blue.svg)
 
 ### utPLSQL v3 Major Contributors 
 
diff --git a/docs/about/license.md b/docs/about/license.md
@@ -1,4 +1,4 @@
-![version](https://img.shields.io/badge/version-v3.1.7.2886--develop-blue.svg)
+![version](https://img.shields.io/badge/version-v3.1.7.2904--develop-blue.svg)
 
 # Version Information
 
diff --git a/docs/about/project-details.md b/docs/about/project-details.md
@@ -1,4 +1,4 @@
-![version](https://img.shields.io/badge/version-v3.1.7.2886--develop-blue.svg)
+![version](https://img.shields.io/badge/version-v3.1.7.2904--develop-blue.svg)
 
 # utPLSQL Project Details
 
diff --git a/docs/about/support.md b/docs/about/support.md
@@ -1,4 +1,4 @@
-![version](https://img.shields.io/badge/version-v3.1.7.2886--develop-blue.svg)
+![version](https://img.shields.io/badge/version-v3.1.7.2904--develop-blue.svg)
 
 # How to get support
 
diff --git a/docs/index.md b/docs/index.md
@@ -1,4 +1,4 @@
-![version](https://img.shields.io/badge/version-v3.1.7.2886--develop-blue.svg)
+![version](https://img.shields.io/badge/version-v3.1.7.2904--develop-blue.svg)
 
 # Introduction to utPLSQL
 
diff --git a/docs/userguide/advanced_data_comparison.md b/docs/userguide/advanced_data_comparison.md
@@ -1,4 +1,4 @@
-![version](https://img.shields.io/badge/version-v3.1.7.2886--develop-blue.svg)
+![version](https://img.shields.io/badge/version-v3.1.7.2904--develop-blue.svg)
 
 # Advanced data comparison
 
diff --git a/docs/userguide/annotations.md b/docs/userguide/annotations.md
@@ -1,4 +1,4 @@
-![version](https://img.shields.io/badge/version-v3.1.7.2886--develop-blue.svg)
+![version](https://img.shields.io/badge/version-v3.1.7.2904--develop-blue.svg)
 
 # Annotations
 
diff --git a/docs/userguide/best-practices.md b/docs/userguide/best-practices.md
@@ -1,4 +1,4 @@
-![version](https://img.shields.io/badge/version-v3.1.7.2886--develop-blue.svg)
+![version](https://img.shields.io/badge/version-v3.1.7.2904--develop-blue.svg)
 
 # Best Practices
 
diff --git a/docs/userguide/coverage.md b/docs/userguide/coverage.md
@@ -1,4 +1,4 @@
-![version](https://img.shields.io/badge/version-v3.1.7.2886--develop-blue.svg)
+![version](https://img.shields.io/badge/version-v3.1.7.2904--develop-blue.svg)
 
 # Coverage
 utPLSQL comes with a built-in coverage reporting engine. The code coverage reporting is based on the DBMS_PROFILER package provided with Oracle database.
diff --git a/docs/userguide/exception-reporting.md b/docs/userguide/exception-reporting.md
@@ -1,4 +1,4 @@
-![version](https://img.shields.io/badge/version-v3.1.7.2886--develop-blue.svg)
+![version](https://img.shields.io/badge/version-v3.1.7.2904--develop-blue.svg)
 
 # Exception handling and reporting
 
diff --git a/docs/userguide/expectations.md b/docs/userguide/expectations.md
@@ -1,4 +1,4 @@
-![version](https://img.shields.io/badge/version-v3.1.7.2886--develop-blue.svg)
+![version](https://img.shields.io/badge/version-v3.1.7.2904--develop-blue.svg)
 
 # Expectation concepts 
 Validation of the code under test (the tested logic of procedure/function etc.) is performed by comparing the actual data against the expected data.
diff --git a/docs/userguide/getting-started.md b/docs/userguide/getting-started.md
@@ -1,4 +1,4 @@
-![version](https://img.shields.io/badge/version-v3.1.7.2886--develop-blue.svg)
+![version](https://img.shields.io/badge/version-v3.1.7.2904--develop-blue.svg)
 
 # Getting started with TDD and utPLSQL
 
diff --git a/docs/userguide/install.md b/docs/userguide/install.md
@@ -1,4 +1,4 @@
-![version](https://img.shields.io/badge/version-v3.1.7.2886--develop-blue.svg)
+![version](https://img.shields.io/badge/version-v3.1.7.2904--develop-blue.svg)
 
 # Downloading latest version of utPLSQL
 
diff --git a/docs/userguide/querying_suites.md b/docs/userguide/querying_suites.md
@@ -1,4 +1,4 @@
-![version](https://img.shields.io/badge/version-v3.1.7.2886--develop-blue.svg)
+![version](https://img.shields.io/badge/version-v3.1.7.2904--develop-blue.svg)
 
 # Qyerying for test suites
 
diff --git a/docs/userguide/reporters.md b/docs/userguide/reporters.md
@@ -1,4 +1,4 @@
-![version](https://img.shields.io/badge/version-v3.1.7.2886--develop-blue.svg)
+![version](https://img.shields.io/badge/version-v3.1.7.2904--develop-blue.svg)
 
 utPLSQL provides the following reporting formats.
 
diff --git a/docs/userguide/running-unit-tests.md b/docs/userguide/running-unit-tests.md
@@ -1,4 +1,4 @@
-![version](https://img.shields.io/badge/version-v3.1.7.2886--develop-blue.svg)
+![version](https://img.shields.io/badge/version-v3.1.7.2904--develop-blue.svg)
 
 # Running tests
 
diff --git a/docs/userguide/upgrade.md b/docs/userguide/upgrade.md
@@ -1,4 +1,4 @@
-![version](https://img.shields.io/badge/version-v3.1.7.2886--develop-blue.svg)
+![version](https://img.shields.io/badge/version-v3.1.7.2904--develop-blue.svg)
 
 # Upgrading from version 2
 
diff --git a/source/core/ut_utils.pkb b/source/core/ut_utils.pkb
@@ -773,7 +773,7 @@ create or replace package body ut_utils is
   /**
   * Change string into unicode to match xmlgen format _00<unicode>_
   * https://docs.oracle.com/en/database/oracle/oracle-database/12.2/adxdb/generation-of-XML-data-from-relational-data.html#GUID-5BE09A7D-80D8-4734-B9AF-4A61F27FA9B2
-  * secion v3.1.7.2886-develop
+  * secion v3.1.7.2904-develop
   */  
   function char_to_xmlgen_unicode(a_character varchar2) return varchar2 is
   begin
diff --git a/source/core/ut_utils.pks b/source/core/ut_utils.pks
@@ -21,7 +21,7 @@ create or replace package ut_utils authid definer is
    *
    */
 
-  gc_version                 constant varchar2(50) := 'v3.1.7.2886-develop';
+  gc_version                 constant varchar2(50) := 'v3.1.7.2904-develop';
     
   subtype t_executable_type      is varchar2(30);
   gc_before_all                  constant t_executable_type := 'beforeall';
diff --git a/test/core/expectations/compound_data/test_expectations_cursor.pkb b/test/core/expectations/compound_data/test_expectations_cursor.pkb
diff --git a/test/core/expectations/compound_data/test_expectations_cursor.pks b/test/core/expectations/compound_data/test_expectations_cursor.pks
diff --git a/test/ut3_user/expectations/test_expectations_cursor.pkb b/test/ut3_user/expectations/test_expectations_cursor.pkb
@@ -2788,6 +2788,48 @@ Check the query and data for errors.';
     ut3.ut.expect(l_actual).to_equal(l_expected);
     ut.expect(ut3_tester_helper.main_helper.get_failed_expectations_num).to_equal(0);
    end;
-  
+
+  procedure compare_number_pckg_type
+  as
+    l_expected sys_refcursor;
+    l_actual   sys_refcursor;
+    l_expected_data t_num_tab;
+    l_actual_message   varchar2(32767);
+    l_expected_message varchar2(32767);
+  begin
+
+    l_expected_data(1).col1 :=  2135;
+    l_expected_data(1).col4 :=  2016;
+    l_expected_data(1).col5 :=  -1;
+
+    --Select on package level nested table types supported only since Oracle 12
+    $if dbms_db_version.version >= 12 $then
+    open l_expected for
+      select *
+        from table (l_expected_data);
+
+    open l_actual for
+      select
+        1 as col1
+        ,2 as col2
+        ,3 as col3
+        ,2016 as col4
+        ,-1 as col5
+      from dual;
+
+    ut3.ut.expect(l_actual).to_equal(a_expected => l_expected);
+
+    l_expected_message := q'[%Actual: refcursor [ count = 1 ] was expected to equal: refcursor [ count = 1 ]
+%Diff:
+%Rows: [ 1 differences ]
+%Row No. 1 - Actual:   <COL1>1</COL1><COL2>2</COL2><COL3>3</COL3>
+%Row No. 1 - Expected: <COL1>2135</COL1><COL2/><COL3/>%]';
+
+    l_actual_message := ut3_tester_helper.main_helper.get_failed_expectations(1);
+
+    ut.expect(l_actual_message).to_be_like(l_expected_message);
+    $end
+  end;
+
 end;
 /
diff --git a/test/ut3_user/expectations/test_expectations_cursor.pks b/test/ut3_user/expectations/test_expectations_cursor.pks
@@ -445,6 +445,19 @@ create or replace package test_expectations_cursor is
 
   --%test(Check precision of number from dual #907)
   procedure number_from_dual;
-  
+
+  --%test( Comparing number types with different precisions works with package-type nested tables )
+  procedure compare_number_pckg_type;
+
+  type t_num_rec is record (
+    col1 number(15,0),
+    col2 number(1,0),
+    col3 number(4,0),
+    col4 number(4,0),
+    col5 number(38,0));
+
+
+  type t_num_tab is table of t_num_rec index by binary_integer;
+
 end;
 /

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-![version](https://img.shields.io/badge/version-v3.1.7.2886--develop-blue.svg)`
	`1`	`+![version](https://img.shields.io/badge/version-v3.1.7.2904--develop-blue.svg)`
`2`	`2`
`3`	`3`	`### utPLSQL v3 Major Contributors`
`4`	`4`