Merge pull request #608 from utPLSQL/feature/distributed_transaction_fix

jgebal · web-flow · commit bcb8cead6d14 · 2018-03-17T12:32:52.000Z
Fixed `ORA-02055` issue.
diff --git a/.travis/install.sh b/.travis/install.sh
@@ -29,6 +29,9 @@ SQL
 set feedback off
 @create_utplsql_owner.sql $UT3_TESTER $UT3_TESTER_PASSWORD $UT3_TABLESPACE
 
+--needed for testing distributed transactions
+grant create public database link to $UT3_TESTER;
+grant drop public database link to  $UT3_TESTER;
 set feedback on
 --Needed for testing coverage outside of main UT3 schema.
 grant create any procedure, drop any procedure, execute any procedure, create any type, drop any type, execute any type, under any type, select any table, update any table, insert any table, delete any table, create any table, drop any table, alter any table, select any dictionary to $UT3_TESTER;
diff --git a/source/api/ut_runner.pkb b/source/api/ut_runner.pkb
@@ -93,11 +93,13 @@ create or replace package body ut_runner is
       l_items_to_run.do_execute(l_listener);
 
       finish_run(l_listener);
+      rollback;
     exception
       when others then
         finish_run(l_listener);
         dbms_output.put_line(dbms_utility.format_error_backtrace);
         dbms_output.put_line(dbms_utility.format_error_stack);
+        rollback;
         raise;
     end;
     if a_fail_on_errors and l_items_to_run.result in (ut_utils.tr_failure, ut_utils.tr_error) then
diff --git a/test/api/test_ut_runner.pkb b/test/api/test_ut_runner.pkb
@@ -295,5 +295,59 @@ end;';
     ut.expect(l_actual).to_equal(l_expected);
   end;
 
+  procedure db_link_cleanup is
+    begin
+      begin execute immediate 'drop public database link db_loopback'; exception when others then null; end;
+      begin execute immediate 'drop package test_db_link'; exception when others then null; end;
+    end;
+
+  procedure db_link_setup is
+    l_service_name varchar2(100);
+    begin
+      select global_name into l_service_name from global_name;
+      execute immediate
+      'create public database link db_loopback connect to ut3_tester identified by ut3
+        using ''(DESCRIPTION=
+                  (ADDRESS=(PROTOCOL=TCP)
+                    (HOST='||sys_context('userenv','SERVER_HOST')||')
+                    (PORT=1521)
+                  )
+                  (CONNECT_DATA=(SERVICE_NAME='||l_service_name||')))''';
+      execute immediate q'[
+    create or replace package test_db_link is
+      --%suite
+
+      --%test
+      procedure runs_with_db_link;
+    end;]';
+
+      execute immediate q'[
+    create or replace package body test_db_link is
+      procedure runs_with_db_link is
+        a_value integer;
+        begin
+          select 1 into a_value
+          from dual@db_loopback;
+          ut3.ut.expect(a_value).to_be_null();
+        end;
+    end;]';
+
+    end;
+
+  procedure raises_20213_on_fail_link is
+    l_reporter ut3.ut_documentation_reporter := ut3.ut_documentation_reporter();
+    l_lines    ut3.ut_varchar2_list;
+  begin
+    --Arrange
+    --Act
+    ut3.ut_runner.run(ut3.ut_varchar2_list('test_db_link'), ut3.ut_reporters(l_reporter), a_fail_on_errors=> true);
+    ut.fail('Expected exception but nothing was raised');
+  exception
+    when others then
+      --Assert
+      ut.expect(sqlcode).to_equal(-20213);
+      ut.expect(dbms_utility.format_error_stack||dbms_utility.format_error_backtrace).not_to_be_like('%ORA-02055%');
+  end;
+
 end;
 /
diff --git a/test/api/test_ut_runner.pks b/test/api/test_ut_runner.pks
@@ -53,5 +53,13 @@ create or replace package test_ut_runner is
   --%aftertest(cleanup_cache)
   procedure test_get_reporters_list;
 
+  procedure db_link_cleanup;
+  procedure db_link_setup;
+
+  --%test(ORA-20213 is thrown with a_raise_on_failure when database link operations are used - regression)
+  --%beforetest(db_link_setup)
+  --%aftertest(db_link_cleanup)
+  procedure raises_20213_on_fail_link;
+
 end;
 /
