addressed reviewer comments.

Pazus · Pazus · commit c067bb6d773e · 2017-08-05T10:28:30.000+03:00
Simplified and made reporting format more verbose
diff --git a/source/core/types/ut_executable.tpb b/source/core/types/ut_executable.tpb
@@ -76,7 +76,6 @@ create or replace type body ut_executable is
     l_completed_without_errors boolean := true;
     l_start_transaction_id     varchar2(250);
     l_end_transaction_id     varchar2(250);
-    l_client_info            varchar2(200);
     procedure save_dbms_output is
       l_status number;
       l_line varchar2(32767);
@@ -98,19 +97,8 @@ create or replace type body ut_executable is
     if self.is_defined() then
       l_start_transaction_id := dbms_transaction.local_transaction_id(true);
       
-      l_client_info := case
-                         when a_item is of(ut_test) then
-                          'Test: '
-                         else
-                          'Suite: '
-                       end || a_item.name || case
-                         when self.associated_event_name = ut_utils.gc_test_execute then
-                          null
-                         else
-                          ' (' || self.associated_event_name || ')'
-                       end;
       -- report to application_info
-      ut_utils.set_client_info(l_client_info);
+      ut_utils.set_client_info(self.procedure_name);
       
       --listener - before call to executable
       a_listener.fire_before_event(self.associated_event_name, a_item);
diff --git a/source/core/types/ut_suite.tpb b/source/core/types/ut_suite.tpb
@@ -41,7 +41,6 @@ create or replace type body ut_suite  as
 
   overriding member function do_execute(self in out nocopy ut_suite, a_listener in out nocopy ut_event_listener_base) return boolean is
     l_suite_savepoint varchar2(30);
-    l_item_savepoint  varchar2(30);
     l_suite_step_without_errors boolean;
 
     procedure propagate_error(a_error_stack_trace varchar2) is
@@ -53,7 +52,7 @@ create or replace type body ut_suite  as
   begin
     ut_utils.debug_log('ut_suite.execute');
     
-    ut_utils.set_action('Suite: '||self.object_name);
+    ut_utils.set_action(self.object_name);
     
     a_listener.fire_before_event(ut_utils.gc_suite,self);
 
diff --git a/tests/ut_test/ut_test.ApplicationInfoOnExecution.sql b/tests/ut_test/ut_test.ApplicationInfoOnExecution.sql
@@ -24,7 +24,7 @@ as
  procedure after_test;
  
  --%aftereach
- procedure after_each;
+ procedure aftereach;
  
  --%afterall
  procedure afterall;
@@ -47,8 +47,8 @@ as
    dbms_application_info.read_module(module_name => l_module_name, action_name => l_action_name);
    dbms_application_info.read_client_info(l_client_info);
    ut.expect(l_module_name).to_equal('utPLSQL');
-   ut.expect(l_action_name).to_be_like('Suite: ut_output_tests');
-   ut.expect(l_client_info).to_be_like('Test: the_test');
+   ut.expect(l_action_name).to_be_like('ut_output_tests');
+   ut.expect(l_client_info).to_be_like('the_test');
  end;
  
  procedure beforeall is 
@@ -70,7 +70,7 @@ as
    dbms_application_info.read_client_info(gv_after_test_client_info);
  end;
  
- procedure after_each is 
+ procedure aftereach is 
  begin 
    dbms_application_info.read_client_info(gv_after_each_client_info);
  end;
@@ -101,32 +101,32 @@ begin
   end loop;
   
   execute immediate 'begin :i := ut_output_tests.gv_before_all_client_info; end;' using out l_client_info;
-  if not nvl(l_client_info = 'Suite: ut_output_tests (before_all)', false) then
+  if not nvl(l_client_info = 'beforeall', false) then
     dbms_output.put_line('Wrong before all text: '||l_client_info);
     l_result := false;
   end if;
   execute immediate 'begin :i := ut_output_tests.gv_before_each_client_info; end;' using out  l_client_info;
-  if not nvl(l_client_info = 'Test: the_test (before_each)', false) then
+  if not nvl(l_client_info = 'beforeeach', false) then
     dbms_output.put_line('Wrong before each text: '||l_client_info);
     l_result := false;
   end if;
   execute immediate 'begin :i := ut_output_tests.gv_before_test_client_info; end;' using out  l_client_info;
-  if not nvl(l_client_info = 'Test: the_test (before_test)', false) then
+  if not nvl(l_client_info = 'before_test', false) then
     dbms_output.put_line('Wrong before test text: '||l_client_info);
     l_result := false;
   end if;
   execute immediate 'begin :i := ut_output_tests.gv_after_test_client_info; end;' using out  l_client_info;
-  if not nvl(l_client_info = 'Test: the_test (after_test)', false) then
+  if not nvl(l_client_info = 'after_test', false) then
     dbms_output.put_line('Wrong after test text: '||l_client_info);
     l_result := false;
   end if;
   execute immediate 'begin :i := ut_output_tests.gv_after_each_client_info; end;' using out  l_client_info;
-  if not nvl(l_client_info = 'Test: the_test (after_each)', false) then
+  if not nvl(l_client_info = 'aftereach', false) then
     dbms_output.put_line('Wrong after each text: '||l_client_info);
     l_result := false;
   end if;
   execute immediate 'begin :i := ut_output_tests.gv_after_all_client_info; end;' using out  l_client_info;
-  if not nvl(l_client_info = 'Suite: ut_output_tests (after_all)', false) then
+  if not nvl(l_client_info = 'afterall', false) then
     dbms_output.put_line('Wrong after all text: '||l_client_info);
     l_result := false;
   end if;
