Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit c491cdc

Browse files
jgebaljgebal
committed
Fixed and improved failing tests.
1 parent aaf4a3a commit c491cdc

3 files changed

Lines changed: 40 additions & 64 deletions

File tree

‎test/core/expectations/compound_data/test_expectation_anydata.pkb‎

Lines changed: 31 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -351,25 +351,18 @@ create or replace package body test_expectation_anydata is
351351
ut.expect(expectations.failed_expectations_data()).to_be_empty();
352352
end;
353353

354-
procedure reports_object_structure is
354+
procedure reports_diff_attribute is
355355
l_expected varchar2(32767);
356356
l_actual varchar2(32767);
357357
begin
358358
--Arrange
359359
g_test_expected := anydata.convertObject( test_dummy_object(1, 'A', '0') );
360360
g_test_actual := anydata.convertObject( test_dummy_object(1, 'B', '0') );
361-
l_expected := q'[%Actual:%
362-
<TEST_DUMMY_OBJECT>
363-
<ID>1</ID>
364-
<name>B</name>
365-
<Value>0</Value>
366-
</TEST_DUMMY_OBJECT>%
367-
was expected to equal:%
368-
<TEST_DUMMY_OBJECT>
369-
<ID>1</ID>
370-
<name>A</name>
371-
<Value>0</Value>
372-
</TEST_DUMMY_OBJECT>%]';
361+
l_expected := q'[Actual: ut3_tester.test_dummy_object was expected to equal: ut3_tester.test_dummy_object
362+
Diff:
363+
Rows: [ 1 differences ]
364+
Row No. 1 - Actual: <name>B</name>
365+
Row No. 1 - Expected: <name>A</name>]';
373366
--Act
374367
ut3.ut.expect( g_test_actual ).to_equal( g_test_expected );
375368
--Assert
@@ -378,35 +371,18 @@ was expected to equal:%
378371
end;
379372

380373

381-
procedure reports_collection_structre is
374+
procedure reports_diff_structure is
382375
l_obj test_dummy_object := test_dummy_object(1, 'A', '0');
383376
l_expected varchar2(32767);
384377
l_actual varchar2(32767);
385378
begin
386379
--Arrange
387380
g_test_expected := anydata.convertCollection( test_dummy_object_list(l_obj) );
388381
g_test_actual := anydata.convertCollection( test_dummy_object_list(l_obj, l_obj) );
389-
l_expected := q'[%Actual:%[ count = % ])
390-
<TEST_DUMMY_OBJECT_LIST>
391-
<TEST_DUMMY_OBJECT>
392-
<ID>1</ID>
393-
<name>A</name>
394-
<Value>0</Value>
395-
</TEST_DUMMY_OBJECT>
396-
<TEST_DUMMY_OBJECT>
397-
<ID>1</ID>
398-
<name>A</name>
399-
<Value>0</Value>
400-
</TEST_DUMMY_OBJECT>
401-
</TEST_DUMMY_OBJECT_LIST>%
402-
was expected to equal:%[ count = % ])
403-
<TEST_DUMMY_OBJECT_LIST>
404-
<TEST_DUMMY_OBJECT>
405-
<ID>1</ID>
406-
<name>A</name>
407-
<Value>0</Value>
408-
</TEST_DUMMY_OBJECT>
409-
</TEST_DUMMY_OBJECT_LIST>%]';
382+
l_expected := q'[Actual: ut3_tester.test_dummy_object_list [ count = 2 ] was expected to equal: ut3_tester.test_dummy_object_list [ count = 1 ]
383+
Diff:
384+
Rows: [ 1 differences ]
385+
Row No. 2 - Extra: <ID>1</ID><name>A</name><Value>0</Value>]';
410386
--Act
411387
ut3.ut.expect( g_test_actual ).to_equal( g_test_expected );
412388
--Assert
@@ -491,13 +467,13 @@ was expected to equal:%[ count = % ])
491467
--Act
492468
ut3.ut.expect(anydata.convertCollection(l_actual)).to_equal(anydata.convertCollection(l_expected));
493469

494-
l_expected_message := q'[Actual: refcursor [ count = 2 ] was expected to equal: refcursor [ count = 2 ]
470+
l_expected_message := q'[Actual: ut3_tester.test_dummy_object_list [ count = 2 ] was expected to equal: ut3_tester.test_dummy_object_list [ count = 2 ]
495471
Diff:
496472
Rows: [ 2 differences ]
497-
Row No. 1 - Actual: <BAD_COL>-1</BAD_COL>
498-
Row No. 1 - Expected: <BAD_COL>1</BAD_COL>
499-
Row No. 2 - Actual: <BAD_COL>-2</BAD_COL>
500-
Row No. 2 - Expected: <BAD_COL>2</BAD_COL>]';
473+
Row No. 1 - Actual: <ID>1</ID><name>Something 1</name><Value>1</Value>
474+
Row No. 1 - Expected: <ID>2</ID><name>Something 2</name><Value>2</Value>
475+
Row No. 2 - Actual: <ID>2</ID><name>Something 2</name><Value>2</Value>
476+
Row No. 2 - Expected: <ID>1</ID><name>Something 1</name><Value>1</Value>]';
501477
l_actual_message := ut3.ut_expectation_processor.get_failed_expectations()(1).message;
502478
--Assert
503479
ut.expect(l_actual_message).to_be_like(l_expected_message);
@@ -510,32 +486,29 @@ Rows: [ 2 differences ]
510486
l_expected_message varchar2(32767);
511487
begin
512488
--Arrange
513-
select test_dummy_object( rownum, 'Something '||rownum, rownum)
514-
bulk collect into l_actual
515-
from dual connect by level <=100;
489+
select test_dummy_object( rn, 'Something '||rn, rn1)
490+
bulk collect into l_actual
491+
from (select rownum * case when mod(rownum,2) = 0 then -1 else 1 end rn,
492+
rownum * case when mod(rownum,4) = 0 then -1 else 1 end rn1
493+
from dual connect by level <=100);
516494
select test_dummy_object( rownum, 'Something '||rownum, rownum)
517495
bulk collect into l_expected
518-
from dual connect by level <=110
519-
order by rownum desc;
496+
from dual connect by level <=110;
520497
--Act
521498
ut3.ut.expect(anydata.convertCollection(l_actual)).to_equal(anydata.convertCollection(l_expected));
522499

523-
l_expected_message := q'[Actual: refcursor [ count = 100 ] was expected to equal: refcursor [ count = 110 ]
500+
l_expected_message := q'[Actual: ut3_tester.test_dummy_object_list [ count = 100 ] was expected to equal: ut3_tester.test_dummy_object_list [ count = 110 ]
524501
Diff:
525502
Rows: [ 60 differences, showing first 20 ]
526-
Row No. 2 - Actual: <BAD_COL>-2</BAD_COL>
527-
Row No. 2 - Expected: <BAD_COL>2</BAD_COL>
528-
Row No. 4 - Actual: <BAD_COL>-4</BAD_COL>
529-
Row No. 4 - Expected: <BAD_COL>4</BAD_COL>
530-
Row No. 6 - Actual: <BAD_COL>-6</BAD_COL>
531-
Row No. 6 - Expected: <BAD_COL>6</BAD_COL>
532-
Row No. 8 - Actual: <BAD_COL>-8</BAD_COL>
533-
Row No. 8 - Expected: <BAD_COL>8</BAD_COL>
503+
Row No. 2 - Actual: <ID>-2</ID><name>Something -2</name>
504+
Row No. 2 - Expected: <ID>2</ID><name>Something 2</name>
505+
Row No. 4 - Actual: <ID>-4</ID><name>Something -4</name><Value>-4</Value>
506+
Row No. 4 - Expected: <ID>4</ID><name>Something 4</name><Value>4</Value>
534507
%
535-
Row No. 38 - Actual: <BAD_COL>-38</BAD_COL>
536-
Row No. 38 - Expected: <BAD_COL>38</BAD_COL>
537-
Row No. 40 - Actual: <BAD_COL>-40</BAD_COL>
538-
Row No. 40 - Expected: <BAD_COL>40</BAD_COL>]';
508+
Row No. 38 - Actual: <ID>-38</ID><name>Something -38</name>
509+
Row No. 38 - Expected: <ID>38</ID><name>Something 38</name>
510+
Row No. 40 - Actual: <ID>-40</ID><name>Something -40</name><Value>-40</Value>
511+
Row No. 40 - Expected: <ID>40</ID><name>Something 40</name><Value>40</Value>]';
539512
l_actual_message := ut3.ut_expectation_processor.get_failed_expectations()(1).message;
540513
--Assert
541514
ut.expect(l_actual_message).to_be_like(l_expected_message);

‎test/core/expectations/compound_data/test_expectation_anydata.pks‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,11 @@ create or replace package test_expectation_anydata is
8787
--%test(Includes only attributes that are not on exclude list)
8888
procedure include_exclude_attrib_list;
8989

90-
--%test(Gives information about objects content in report)
91-
procedure reports_object_structure;
90+
--%test(Reports diff on incorrect attributes of an object type)
91+
procedure reports_diff_attribute;
9292

93-
--%test(Gives information about collections content in report)
94-
procedure reports_collection_structre;
93+
--%test(Reports diff on incorrect rows and attributes of a collection type)
94+
procedure reports_diff_structure;
9595

9696
--%test(Adds a warning when using depreciated syntax to_equal( a_expected anydata, a_exclude varchar2 ))
9797
procedure deprec_to_equal_excl_varch;

‎test/core/expectations/compound_data/test_expectations_cursor.pkb‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -695,9 +695,10 @@ Rows: [ 2 differences ]
695695
--Arrange
696696
open l_actual for
697697
select rownum
698-
* case when mod(rownum,2) = 0 then -1 else 1 end bad_col
698+
* case when mod(rownum,2) = 0 then -1 else 1 end bad_col,
699+
rownum good_col
699700
from dual connect by level <=100;
700-
open l_expected for select rownum bad_col from dual connect by level <=110;
701+
open l_expected for select rownum bad_col, rownum good_col from dual connect by level <=110;
701702
--Act
702703
ut3.ut.expect(l_actual).to_equal(l_expected);
703704

@@ -729,6 +730,7 @@ Rows: [ 60 differences, showing first 20 ]
729730
l_expected_message varchar2(32767);
730731
begin
731732
--Arrange
733+
ut3.ut.set_nls();
732734
open l_actual for
733735
select 10 id, 'Norris' last_name, 'Chuck' first_name, systimestamp as create_tmstmp, user as created_by from dual union all
734736
select 20 id, 'Skywalker' last_name, 'Luke' first_name, systimestamp as create_tmstmp, user as created_by from dual union all
@@ -740,6 +742,7 @@ Rows: [ 60 differences, showing first 20 ]
740742
select 31 id, 'Teddy' first_name, 'Bear' last_name, sysdate as birth_date from dual union all
741743
select 40 id, 'Brandon' first_name, 'Lee' last_name, sysdate as birth_date from dual union all
742744
select 50 id, 'Mona' first_name, 'Lisa' last_name, date '1550-01-01' as birth_date from dual;
745+
ut3.ut.reset_nls();
743746
--Act
744747
ut3.ut.expect(l_actual).to_equal(l_expected);
745748
l_expected_message := q'[%Actual: refcursor [ count = 4 ] was expected to equal: refcursor [ count = 5 ]

0 commit comments

Comments
 (0)