Fixed failing tests and refactored sonar reporter.

jgebal · jgebal · commit c960d4443d29 · 2017-08-13T17:07:26.000+01:00
diff --git a/source/reporters/ut_coverage_sonar_reporter.tpb b/source/reporters/ut_coverage_sonar_reporter.tpb
@@ -42,13 +42,11 @@ create or replace type body ut_coverage_sonar_reporter is
         end loop;
       else
         while l_line_no is not null loop
-          l_file_part :=
-            case a_unit_coverage.lines(l_line_no)
-              when 0 then
-                '<lineToCover lineNumber="'||l_line_no||'" covered="false"/>'||chr(10)
-              else
-                '<lineToCover lineNumber="'||l_line_no||'" covered="true"/>'||chr(10)
-            end;
+          if a_unit_coverage.lines(l_line_no) = 0 then
+            l_file_part := '<lineToCover lineNumber="'||l_line_no||'" covered="false"/>'||chr(10);
+          else
+            l_file_part := '<lineToCover lineNumber="'||l_line_no||'" covered="true"/>'||chr(10);
+          end if;
           ut_utils.append_to_clob(l_result, l_file_part);
           l_line_no := a_unit_coverage.lines.next(l_line_no);
         end loop;
diff --git a/test/ut_reporters/test_coverage.pkb b/test/ut_reporters/test_coverage.pkb
@@ -5,7 +5,7 @@ create or replace package body test_coverage is
   function get_mock_run_id return integer is
     v_result integer;
   begin
-    select min(runid) - 1 into v_result
+    select nvl(min(runid),0) - 1 into v_result
       from ut3.plsql_profiler_runs;
     return v_result;
   end;
