add simple naming check script. compile with warnings. ignore warnings in install error check

Shoelace · Shoelace · commit dbb7a07f6894 · 2016-10-20T11:14:22.000+01:00
diff --git a/.travis/install.sh b/.travis/install.sh
@@ -5,3 +5,9 @@ set -ev
 cd source
 #install core of utplsql
 "$ORACLE_HOME/bin/sqlplus" $UT3_USER/$UT3_PASSWORD @install.sql
+
+
+cd ..
+cd build
+#do style check
+"$ORACLE_HOME/bin/sqlplus" $UT3_USER/$UT3_PASSWORD @utplsql_style_check.sql
diff --git a/build/utplsql_style_check.sql b/build/utplsql_style_check.sql
@@ -0,0 +1,49 @@
+--ALTER SESSION SET PLSCOPE_SETTINGS= 'IDENTIFIERS:ALL';
+
+--install or comple all code here
+--exec dbms_utility.compile_schema(USER,compile_all => TRUE,reuse_settings => FALSE);
+
+
+var errcnt number
+
+column errcnt_a noprint new_value errcnt_a
+column errcnt_l noprint new_value errcnt_l
+column errcnt_c noprint new_value errcnt_c
+
+--find parameters that donot begin with A_
+prompt parameters should start with A_
+select NAME,TYPE,OBJECT_NAME,OBJECT_TYPE,USAGE,LINE,COL , count(*) over() errcnt_a
+from user_identifiers
+where type like 'FORMAL%' and usage = 'DECLARATION'
+and name != 'SELF'
+and name  not like 'A#_%' escape '#'
+order by object_name, object_type, line, col
+;
+
+prompt variables should start with L_
+--variables start with l_ or g_
+select NAME,TYPE,OBJECT_NAME,OBJECT_TYPE,USAGE,LINE,COL , count(*) over() errcnt_l
+from user_identifiers
+where type like 'VARIABLE' and usage = 'DECLARATION'
+and object_type not in ('TYPE')
+and (name  not like 'L#_%' escape '#'
+and name  not like 'G#_%' escape '#' --TODO: only valid on package level
+)
+order by object_name, object_type, line, col
+;
+
+--constants start with c_ or gc_
+prompt constants should start with C_
+select NAME,TYPE,OBJECT_NAME,OBJECT_TYPE,USAGE,LINE,COL , count(*) over() errcnt_c
+from user_identifiers
+where type like 'CONSTANT' and usage = 'DECLARATION'
+and (name  not like 'C#_%' escape '#'
+and name  not like 'GC#_%' escape '#'
+)
+order by object_name, object_type, line, col
+;
+
+
+exec  :errcnt := nvl('&errcnt_a',0) + nvl('&errcnt_l',0) + nvl('&errcnt_c',0); 
+
+quit :errcnt
diff --git a/source/install.sql b/source/install.sql
@@ -1,5 +1,12 @@
 prompt Installing utplsql framework
 
+set serveroutput on size unlimited 
+set timing off
+set define off
+
+ALTER SESSION SET PLSQL_WARNINGS = 'ENABLE:ALL', 'DISABLE:(6000,6001,6003,6010, 7206)';
+
+
 whenever sqlerror exit failure rollback
 whenever oserror exit failure rollback
 
@@ -126,14 +133,20 @@ whenever oserror exit failure rollback
 
 
 prompt Validating installation
-select * from user_errors where name not like 'BIN$%' and (name like 'UT%' or name in ('EQUAL','BE_TRUE','BE_FALSE','BE_NULL','BE_NOT_NULL','MATCH','BE_LIKE'));
+select * from user_errors 
+where name not like 'BIN$%'  --not recycled
+and (name like 'UT%' or name in ('BE_FALSE','BE_LIKE','BE_NOT_NULL','BE_NULL','BE_TRUE','EQUAL','MATCH')) -- utplsql objects
+and attribute = 'ERROR'; -- erors only. ignore warnings
 
 declare
   l_cnt integer;
 begin
   select count(1)
     into l_cnt
-    from user_errors where name not like 'BIN$%' and (name like 'UT%' or name in ('EQUAL','BE_TRUE','BE_FALSE','BE_NULL','BE_NOT_NULL','MATCH','BE_LIKE'));
+    from user_errors
+	where name not like 'BIN$%'
+    and (name like 'UT%' or name in ('BE_FALSE','BE_LIKE','BE_NOT_NULL','BE_NULL','BE_TRUE','EQUAL','MATCH'))
+    and attribute = 'ERROR';
   if l_cnt > 0 then
     raise_application_error(-20000, 'Not all sources were successfully installed.');
   end if;
