Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit ff4ede8

Browse files
committed
addressed the reviewer comments
1 parent 8813b77 commit ff4ede8

2 files changed

Lines changed: 2 additions & 7 deletions

File tree

source/core/ut_suite_manager.pkb

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -424,14 +424,11 @@ create or replace package body ut_suite_manager is
424424
end clean_paths;
425425

426426
procedure skip_by_path(a_suite in out nocopy ut_suite_item, a_path varchar2) is
427-
--c_root constant varchar2(32767) := replace(regexp_substr(a_path, '[A-Za-z0-9$#_]+'), '$', '\$');
428427
c_root constant varchar2(32767) := upper(regexp_substr(a_path, '[A-Za-z0-9$#_]+'));
429428
c_rest_path constant varchar2(32767) := regexp_substr(a_path, '\.(.+)', subexpression => 1);
430429
l_suite ut_logical_suite;
431430
l_item ut_suite_item;
432431
l_items ut_suite_items := ut_suite_items();
433-
l_item_name varchar2(32767);
434-
435432
begin
436433
if a_path is not null and a_suite is not null and a_suite is of (ut_logical_suite) then
437434
l_suite := treat(a_suite as ut_logical_suite);
@@ -440,9 +437,7 @@ create or replace package body ut_suite_manager is
440437

441438
l_item := l_suite.items(i);
442439

443-
l_item_name := l_item.name;
444-
--l_item_name := regexp_substr(l_item_name,'[A-Za-z0-9$#_]+$'); -- temporary fix. seems like suite have suitepath in object_name
445-
if upper(l_item_name) = c_root then
440+
if upper(l_item.name) = c_root then
446441

447442
skip_by_path(l_item, c_rest_path);
448443
l_items.extend;

test/ut_suite_manager/test_suite_manager.pks

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ create or replace package test_suite_manager is
133133
--%disabled
134134
--procedure IncludesPackagesWithSutePath;
135135

136-
--%test
136+
--%test(only the defined in suitepath suite/test is executed if multiple similarly named test suites exist in the context differed only by comment)
137137
--%beforetest(setup_pck_with_same_path)
138138
--%aftertest(clean_pck_with_same_path)
139139
procedure test_pck_with_same_path;

0 commit comments

Comments
 (0)