Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Ability to report coverage on long lines. #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

jgebal
Copy link
Member

@jgebal jgebal commented Oct 18, 2022

Sourcecode lines that result in more than 4000 chars after conversion to HTML should be reported successfully.
Resolves: #1232

Sourcecode lines that result in more than 4000 chars after conversion to HTML should be reported successfully.
Resolves: #1232
@jgebal jgebal added the bugfix label Oct 18, 2022
@jgebal jgebal added this to the 3.1.13 milestone Oct 18, 2022
@jgebal jgebal self-assigned this Oct 18, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2022

Unit Test Results

       1 files         2 suites   2m 44s ⏱️
1 051 tests 1 047 ✔️ 4 💤 0
1 054 runs  1 046 ✔️ 8 💤 0

Results for commit 8270715.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 94.45% // Head: 95.13% // Increases project coverage by +0.67% 🎉

Coverage data is based on head (8270715) compared to base (e71571a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1240      +/-   ##
===========================================
+ Coverage    94.45%   95.13%   +0.67%     
===========================================
  Files          108      108              
  Lines         5089     5093       +4     
  Branches        22       22              
===========================================
+ Hits          4807     4845      +38     
+ Misses         274      240      -34     
  Partials         8        8              
Flag Coverage Δ
11XE 94.52% <100.00%> (+0.77%) ⬆️
12.1EE 94.54% <100.00%> (+0.77%) ⬆️
18XE 94.78% <100.00%> (+0.67%) ⬆️
21XE 94.96% <100.00%> (+0.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ource/reporters/ut_coverage_report_html_helper.pkb 80.35% <100.00%> (+27.57%) ⬆️
source/core/ut_utils.pkb 94.44% <0.00%> (+0.24%) ⬆️
source/core/coverage/ut_coverage_helper.pkb 100.00% <0.00%> (+15.38%) ⬆️
source/core/types/ut_object_name.tpb 100.00% <0.00%> (+20.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@PhilippSalvisberg PhilippSalvisberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgebal looks good. Thank you very much!

@jgebal jgebal merged commit 65db189 into develop Oct 19, 2022
@jgebal jgebal deleted the bugfix/coverage_html_report_on_long_lines branch October 19, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ut_coverage_html_reporter crashes when code under test contain lines larger than 1911 characters
2 participants