Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Install and Uninstall scripts are now much more readable#362

Merged
jgebal merged 4 commits intoutPLSQL:developfrom
jgebal:feature/improved_install_scripts
Jun 27, 2017
Merged

Install and Uninstall scripts are now much more readable#362
jgebal merged 4 commits intoutPLSQL:developfrom
jgebal:feature/improved_install_scripts

Conversation

@jgebal
Copy link
Copy Markdown
Member

@jgebal jgebal commented Jun 23, 2017

Resolves #321

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 23, 2017

Coverage Status

Coverage remained the same at 91.708% when pulling 31461ae on jgebal:feature/improved_install_scripts into 482d7d7 on utPLSQL:develop.

Copy link
Copy Markdown
Member

@Pazus Pazus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, but I'd skip "No error" message if there were no errors. What do you think? Look through the log.

@jgebal
Copy link
Copy Markdown
Member Author

jgebal commented Jun 26, 2017

Hi @Pazus, to get this done, we would need to get rid of the show errors.
That could be fine, as we still display the summary of all errors at the end.

We might want to tweak this so that the error report is more readable.
One more thing to change would be to conditionally deply the proftab.sql
It should only be installed only if one of profiler tables or the sequence is missing.
This way we will have install script running without any errors.

@jgebal
Copy link
Copy Markdown
Member Author

jgebal commented Jun 26, 2017

@Pazus , your comment should now be adressed.
Please review.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.07%) to 91.776% when pulling c4b467e on jgebal:feature/improved_install_scripts into 65d0169 on utPLSQL:develop.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.07%) to 91.776% when pulling e1a3fa7 on jgebal:feature/improved_install_scripts into 65d0169 on utPLSQL:develop.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.07%) to 91.776% when pulling 95b1a9f on jgebal:feature/improved_install_scripts into 65d0169 on utPLSQL:develop.

@jgebal jgebal merged commit 006ce6f into utPLSQL:develop Jun 27, 2017
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.07%) to 91.776% when pulling fba1291 on jgebal:feature/improved_install_scripts into 65d0169 on utPLSQL:develop.

@jgebal jgebal deleted the feature/improved_install_scripts branch June 29, 2017 22:18
Pazus added a commit that referenced this pull request Jul 18, 2017
### Documentation
  #399 Documentation now refers to [migration](https://github.com/utPLSQL/utPLSQL-v2-v3-migration) project
  #386 Documentation now refers to a valid object name: `ut_file_mapping`
  #362 Install and Uninstall scripts are now much more readable
  #361 Install guide now provides snippet on how to download latest release on Windows

### Installation
  #396 Added override user/password/tablespace for install_headless
  #384 Installation is now smooth even if profiler tables already exist

### Internal improvements
  #388 Improved reporting from RunTest
  #363 Fixed publishing of release documentation history

### Improvements and fixes
  #407 Fixed rare issue with `ORA-22813: operand value exceeds system limits`
  #403 Stack trace is now properly parsed on all machines
  #397 The `--%disabled` annotation on suite level is now reporting all tests as disabled
  #395 Coverage reporting is now properly filtering test packages on that use suitepath
  #390 Line of code for failed expectation is now also shown for unit tests owned by other users
  #380 Line no of failed test is now properly reported when using `ut.fail`
  #375 Annotation parameter list can now have spaces before/after brackets
  #373 Warnings in documentation reporter are now properly numbered
  #372 Documentation reporter is now providing a timing information for each test
  #370 by xUnit reporter now displays name of the package/procedure if suite/test has no description
  #369 Fixed errors with multi-byte characters in conversion from/to clob
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants