Merged
Conversation
Moved all shortcuts directly to `ut_expectation`. The original design was over-complicated and made it hard to write new code and understand existing code. With that change, one behavior related to the shortcuts (`to_equal` etc.) will change. Currently: - line `ut.expect(1).to_be_empty();` will give compilation error: `PLS-00302: component 'TO_BE_EMPTY' must be declared` - line `ut.expect(1).to_(be_empty());` will compile successfully and on execution expectation fails with message: `The matcher 'to_be_empty' cannot be used with data type (number).` After simplification, both will compile and both will make expectation fail. This change brings simplification to the code-base and improves consistency of the framework. As a side note, The failure message from the framework is much more readable and easy to understand than the compilation error from Oracle.
viniciusam
approved these changes
Oct 16, 2017
# Conflicts: # source/uninstall.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved all shortcuts directly to
ut_expectation.The original design was over-complicated and made it hard to write new code and understand existing code.
With that change, one behavior related to the shortcuts (
to_equaletc.) will change.Currently:
ut.expect(1).to_be_empty();will give compilation error:PLS-00302: component 'TO_BE_EMPTY' must be declaredut.expect(1).to_(be_empty());will compile successfully and on execution expectation fails with message:The matcher 'to_be_empty' cannot be used with data type (number).After simplification, both will compile and both will make expectation fail.
This change brings simplification to the code-base and improves consistency of the framework.
As a side note, the failure message from the framework is much more readable and easy to understand than the compilation error from Oracle.