-
Notifications
You must be signed in to change notification settings - Fork 186
Tags for tests and suites #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
If we introduce tags we should probably also give a way to say "run all tests except tag 'x'". What do you think? |
Absolutely. |
How we would like to invoke it? New parameter? That's simplest option probably. As a path? But then we would need to include a keyword to differeniate between real database object etc. |
We currently use: |
Tags would be just amotjlher way of expressing suitepaths to include. |
I vote for providing tags as a separate parameter. I think it’s ortogonal to the scope of tests to search and execute. With path we set a scope of tests, with tags we filter it further. So I vote for another overload with tags parameter accepting a single/list of values that are applied on provided path. |
It's a valid point that address a name uniqueness domain as well. |
I was thonking a bit differently. Exclusion would come as a separate feature and would be applicable to all three patterns for specifying elements to run. Exclusuin could be applied by adding Tags could be identified in input list by special leading character
Maybe we should start by writing potential input param combinations and describe how it should behave before we make final decission on combining it into path parameter or making it separate parameter. |
It's a great idea but I'm worried about complexity of syntax. New parameter is it extra option indeed but is easier to remember than a special keyword. |
Happy with a special character I think the common one is hash so I'm thinking
This however can lead to ambiguity when package start with hash. |
Possible options to callout the tags are below. 1.
2.
Option 1 Pros
Cons
Option 2 Pros
Cons
Given that tags are treated as a way to filter down a execution path to certain area I'm leaning towards the option 2 as better one. |
I also prefer the second one. It’s simpler and clearer for reading and we read code much more then we write it. Just an idea: we have an increasing number of parameter combinations for |
After some thinking... Builder could be an option to go with but I would separate it from this issue. We could embed the builder in ut_run type directly. |
Introduce annotations to tag tests and suites.
Implement filters on execution procedures to include/exclude suites/tests by tags.
We should discuss if "tag" should be assigned to a suite or "suite_type" with predetermined values fits bettet.
The text was updated successfully, but these errors were encountered: