Feature/improve coverage source query #981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jgebal, I confirm the change that @fabiopan has done is already in our DB and works beautifully. We've been generating the Coverage Report since the last couple days without any problem and its line number is accurate. We did some improvement in the original workaround, so the version @fabiopan has posted is the lastest one. |
PhilippSalvisberg
approved these changes
Jul 18, 2019
|
The code is much more readable due to the code templates. And the query does not need subqueries anymore. That’s good. However, the optimizer has still the freedom to completely rewrite the statement. If this results in a bad plan (for all/dba_source access) then further named subqueries to isolate all/dba_source access with a no_merge or materialize hint might help. I’d go with this change “as is” now. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #970
@rafael-trevisan - Will you be able to apply the changed package body on your DB, that was causing problems and confirm that it is working as expected?
This PR includes a different solution to the one your DBA has applied but it should also work fine.
The changed query syntax also applies some readability improvements to the code.