-
Notifications
You must be signed in to change notification settings - Fork 186
Allow to run utPLSQL without certain tags (ut.run(a_tags=>'-notThisTag')) #983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @pesse |
@lwasylow Also, it looks like we silently remove/ignore tags that are not single_words with this line of code: We should probably put warnings on tag names that are not valid (before we filter them out). |
This is due to:
(given from: http://utplsql.org/utPLSQL/v3.1.7/userguide/annotations.html) |
Yes, will fix that and add a warning about it. |
I support @pesse 's approach of adding "minus" as a prefix to the tags for the tests that must be excluded:
Yes, as to me this is correct. Consider a use case scenario: test case is marked as
and other test cases have other tags or have no tags at all.
then I expect that will be executed ALL test cases EXCEPT those marked with "long_running" tag.
then I expect that will be executed ALL test cases EXCEPT those marked with "long_running" tag PLUS those that marked with "wip". In a conflict situation, when we have intersecting sets:
and when we call:
or
then I expect that will be ALL test cases EXCEPT those marked with "long_running" tag PLUS those that marked with "wip" EXCEPT those marked with "long_running" again. I.e. in example above will be run only
But now this MY expectation goes against the "OR" rule of annotations (http://utplsql.org/utPLSQL/v3.1.7/userguide/annotations.html):
That's why I'd considered a change to the "OR" rule for annotations and made it this way:
What would you say? |
I would say:
and when we call This is because of the exclusion logic. So we say:
The
When you combine filtering by suitepath and filtering by tag |
@lwasylow - I'm already making changes for tags |
@jgebal, I totally agree with you saying:
And thank you very much for making changes for tags already! Tags are very important for automation tools usages. |
@alexeyhimself |
@jgebal, thank you very much! |
Also, cli already supports it. You can just go
with 3.1.8 cli against 3.1.9 core |
@pesse, yes, I've seen that in utPLSQL-cli repo! And I really appreciate that! Thank you! |
Is your feature request related to a problem? Please describe.
Playing around with tags, for me it is often much easier to tag several problematic (or long-running) tests which I don't want to run in several situtations.
Describe the solution you'd like
Would be great to enable ut-runner Tags-parameter to allow
-tag
:This would run all tests which don't have the
long_running
tag.This would run all tests that have the
wip
tag but not thelong_running
tagAdditional context
We discussed an alternative approach with logic AND/OR operators (
a_tags => 'tag1&tag2|tag3
) but the-
seems much more useful.The text was updated successfully, but these errors were encountered: