configure default fetch size of 100 (except for consumeReport)

PhilippSalvisberg · PhilippSalvisberg · commit e677de759f45 · 2020-05-30T19:13:41.000+02:00
diff --git a/sqldev/src/main/java/org/utplsql/sqldev/dal/RealtimeReporterDao.java b/sqldev/src/main/java/org/utplsql/sqldev/dal/RealtimeReporterDao.java
@@ -64,7 +64,7 @@ public class RealtimeReporterDao {
     public RealtimeReporterDao(final Connection conn) {
         this.conn = conn;
         jdbcTemplate = new JdbcTemplate(new SingleConnectionDataSource(conn, true));
-        jdbcTemplate.setFetchSize(1);
+        jdbcTemplate.setFetchSize(UtplsqlDao.FETCH_ROWS);
     }
 
     public boolean isSupported() {
@@ -143,26 +143,31 @@ public void consumeReport(final String reporterId, final RealtimeReporterEventCo
         sb.append("   ? := l_reporter.get_lines_cursor();\n");
         sb.append("END;");
         final String plsql = sb.toString();
-        jdbcTemplate.execute(plsql, new CallableStatementCallback<Void>() {
-            @Override
-            public Void doInCallableStatement(final CallableStatement cs) throws SQLException {
-                cs.setString(1, reporterId);
-                cs.registerOutParameter(2, OracleTypes.CURSOR);
-                cs.execute();
-                final ResultSet rs = (ResultSet) cs.getObject(2);
-                while (rs.next()) {
-                    final String itemType = rs.getString("item_type");
-                    final Clob textClob = rs.getClob("text");
-                    final String textString = textClob.getSubString(1, ((int) textClob.length()));
-                    final RealtimeReporterEvent event = convert(itemType, textString);
-                    if (event != null) {
-                        consumer.process(event);
+        jdbcTemplate.setFetchSize(1);
+        try {
+            jdbcTemplate.execute(plsql, new CallableStatementCallback<Void>() {
+                @Override
+                public Void doInCallableStatement(final CallableStatement cs) throws SQLException {
+                    cs.setString(1, reporterId);
+                    cs.registerOutParameter(2, OracleTypes.CURSOR);
+                    cs.execute();
+                    final ResultSet rs = (ResultSet) cs.getObject(2);
+                    while (rs.next()) {
+                        final String itemType = rs.getString("item_type");
+                        final Clob textClob = rs.getClob("text");
+                        final String textString = textClob.getSubString(1, ((int) textClob.length()));
+                        final RealtimeReporterEvent event = convert(itemType, textString);
+                        if (event != null) {
+                            consumer.process(event);
+                        }
                     }
+                    rs.close();
+                    return null;
                 }
-                rs.close();
-                return null;
-            }
-        });
+            });
+        } finally {
+            jdbcTemplate.setFetchSize(UtplsqlDao.FETCH_ROWS);
+        }
     }
 
     public String getHtmlCoverage(final String reporterId) {
diff --git a/sqldev/src/main/java/org/utplsql/sqldev/dal/UtplsqlDao.java b/sqldev/src/main/java/org/utplsql/sqldev/dal/UtplsqlDao.java
@@ -42,6 +42,7 @@ public class UtplsqlDao {
     public static final int FIRST_VERSION_WITH_ANNOTATION_API = 3001003;
     public static final int FIRST_VERSION_WITHOUT_INTERNAL_API = 3001008;
     public static final int FIRST_VERSION_WITH_HAS_SUITES_API = 3001008;
+    public static final int FETCH_ROWS = 100;
     private JdbcTemplate jdbcTemplate;
     // cache fields
     private Boolean cachedDbaViewAccessible;
@@ -50,6 +51,7 @@ public class UtplsqlDao {
 
     public UtplsqlDao(final Connection conn) {
         jdbcTemplate = new JdbcTemplate(new SingleConnectionDataSource(conn, true));
+        jdbcTemplate.setFetchSize(FETCH_ROWS);
     }
 
     /**
