From 77f9f0bc526bafec2c79097e010585c17f2984e5 Mon Sep 17 00:00:00 2001
From: Philipp Salvisberg <philipp.salvisberg@trivadis.com>
Date: Mon, 4 Jan 2021 09:44:56 +0100
Subject: [PATCH 1/2] fixes #124 handles double-click event on tree-table view

open package body at the position of the first failed assert when a test is selected.
open the package spec at the position of test declaration when a test is selected.
open the package spec at line 1 if a the node contains only one package.
---
 .../utplsql/sqldev/ui/runner/RunnerPanel.java | 74 +++++++++++++++----
 1 file changed, 61 insertions(+), 13 deletions(-)

diff --git a/sqldev/src/main/java/org/utplsql/sqldev/ui/runner/RunnerPanel.java b/sqldev/src/main/java/org/utplsql/sqldev/ui/runner/RunnerPanel.java
index 145dde2..fec6c0e 100644
--- a/sqldev/src/main/java/org/utplsql/sqldev/ui/runner/RunnerPanel.java
+++ b/sqldev/src/main/java/org/utplsql/sqldev/ui/runner/RunnerPanel.java
@@ -405,6 +405,19 @@ public boolean include(final RowFilter.Entry<? extends TestOverviewTableModel, ?
         }
     }
         
+    private void openItemNode(final ItemNode node) {
+        if (!node.getPackageName().equals("***")) {
+            final UtplsqlDao dao = new UtplsqlDao(DatabaseTools.getConnection(currentRun.getConnectionName()));
+            final String source = dao.getSource(node.getOwnerName(), "PACKAGE", node.getPackageName().toUpperCase()).trim();
+            final UtplsqlParser parser = new UtplsqlParser(source);
+            int line = 1;
+            if (node.getUserObject() instanceof Test) {
+                line = parser.getLineOf(node.getProcedureName());
+            }
+            openEditor(node.getOwnerName(), "PACKAGE", node.getPackageName().toUpperCase(), line, 1);
+        }
+    }
+
     private void openTest(final Test test) {
             final UtplsqlDao dao = new UtplsqlDao(DatabaseTools.getConnection(currentRun.getConnectionName()));
             final String source = dao.getSource(test.getOwnerName(), "PACKAGE", test.getObjectName().toUpperCase()).trim();
@@ -414,11 +427,21 @@ private void openTest(final Test test) {
     }
 
     private void openSelectedTest() {
-        final int rowIndex = testOverviewTable.getSelectedRow();
-        if (rowIndex != -1) {
-            final int row = testOverviewTable.convertRowIndexToModel(rowIndex);
-            final Test test = testOverviewTableModel.getTest(row);
-            openTest(test);
+        if (!showSuitesCheckBoxMenuItem.isSelected()) {
+            // table
+            final int rowIndex = testOverviewTable.getSelectedRow();
+            if (rowIndex != -1) {
+                final int row = testOverviewTable.convertRowIndexToModel(rowIndex);
+                final Test test = testOverviewTableModel.getTest(row);
+                openTest(test);
+            }
+        } else {
+            // tree-table
+            TreePath path = testOverviewTreeTable.getTree().getSelectionPath();
+            if (path != null) {
+                ItemNode itemNode = (ItemNode) path.getLastPathComponent();
+                openItemNode(itemNode);
+            }
         }
     }
 
@@ -427,14 +450,27 @@ private void openSelectedFailure() {
         if (rowIndex != -1) {
             final int row = failuresTable.convertRowIndexToModel(rowIndex);
             final Expectation expectation = failuresTableModel.getExpectation(row);
-            final Test test = testOverviewTableModel
-                    .getTest(testOverviewTable.convertRowIndexToModel(testOverviewTable.getSelectedRow()));
-            final Integer callerLine = expectation.getCallerLine();
-            if (callerLine != null) {
-                openEditor(test.getOwnerName(), "PACKAGE BODY", test.getObjectName().toUpperCase(),
-                        expectation.getCallerLine(), 1);
+            Test test = null;
+            if (!showSuitesCheckBoxMenuItem.isSelected()) {
+                // table
+                test = testOverviewTableModel
+                        .getTest(testOverviewTable.convertRowIndexToModel(testOverviewTable.getSelectedRow()));
             } else {
-                openTest(test);
+                // tree-table
+                TreePath path = testOverviewTreeTable.getTree().getSelectionPath();
+                if (path != null) {
+                    ItemNode itemNode = (ItemNode) path.getLastPathComponent();
+                    test = ((Test)itemNode.getUserObject());
+                }
+            }
+            if (test != null) {
+                final Integer callerLine = expectation.getCallerLine();
+                if (callerLine != null) {
+                    openEditor(test.getOwnerName(), "PACKAGE BODY", test.getObjectName().toUpperCase(),
+                            expectation.getCallerLine(), 1);
+                } else {
+                    openTest(test);
+                }
             }
         }
     }
@@ -1412,7 +1448,19 @@ public Component getTableCellRendererComponent(final JTable table, final Object
                 testOverviewCodeCoverageMenuItem.setEnabled(true);
             }
         });
-        
+        testOverviewTreeTable.addMouseListener(new MouseAdapter() {
+            @Override
+            public void mouseClicked(final MouseEvent e) {
+                if (e.getClickCount() == 2) {
+                    if (failuresTable.getSelectedRowCount() == 1) {
+                        // open failure only if a Test node is selected
+                        openSelectedFailure();
+                    } else {
+                        openSelectedTest();
+                    }
+                }
+            }
+        });        
         final JTree overviewTreeTableName = testOverviewTreeTable.getTree();
         overviewTreeTableName.setCellRenderer(new DefaultTreeCellRenderer() {
             private static final long serialVersionUID = 580783625740405285L;

From 78f0ae85224234993a4b2a8b5d8bc631a9ea4fb1 Mon Sep 17 00:00:00 2001
From: Philipp Salvisberg <philipp.salvisberg@trivadis.com>
Date: Mon, 4 Jan 2021 10:02:18 +0100
Subject: [PATCH 2/2] fixes #118 (again) spaces are encoded as plus signs in
 connection names

---
 sqldev/src/main/java/org/utplsql/sqldev/model/URLTools.java | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/sqldev/src/main/java/org/utplsql/sqldev/model/URLTools.java b/sqldev/src/main/java/org/utplsql/sqldev/model/URLTools.java
index de225bc..26190df 100644
--- a/sqldev/src/main/java/org/utplsql/sqldev/model/URLTools.java
+++ b/sqldev/src/main/java/org/utplsql/sqldev/model/URLTools.java
@@ -43,7 +43,9 @@ public static String getConnectionName(final URL url) {
         final Pattern p = Pattern.compile("(sqldev.nav:)([^/]+)(//)?");
         final Matcher m = p.matcher(url.toString());
         if (m.find()) {
-            return replaceHexChars(m.group(2).replace("IdeConnections%2523", "IdeConnections%23"));
+            return replaceHexChars(m.group(2)
+                    .replace("IdeConnections%2523", "IdeConnections%23")) // remove connection prefix
+                    .replace("+", " "); // spaces are encoded als plus signs, fix that, see #118
         } else {
             return "";
         }