Thanks to visit codestin.com
Credit goes to github.com

Skip to content

command line options failing #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jgebal opened this issue Aug 3, 2017 · 4 comments
Closed

command line options failing #29

jgebal opened this issue Aug 3, 2017 · 4 comments
Labels
bug

Comments

@jgebal
Copy link
Member

jgebal commented Aug 3, 2017

I would expect the below command to succeed:

utPLSQL-cli/bin/utplsql run ${UT3_TESTER}/${UT3_TESTER_PASSWORD}@${CONNECTION_STR} \
-source_path=source -test_path=tests \
-f=ut_documentation_reporter  -c -o=test_results.log -s \
-f=ut_coverage_sonar_reporter -o=coverage.xml \
-f=ut_sonar_test_reporter     -o=test_results.xml

It fails however reporting invalid parameter values:
https://travis-ci.org/utPLSQL/utPLSQL/jobs/260426161#L5844

The line that is causing the issues is:
-f=ut_documentation_reporter -c -o=test_results.log -s
it was working fine when I used:
-f=ut_documentation_reporter -c

@jgebal jgebal added the bug label Aug 3, 2017
@viniciusam
Copy link
Member

I don't treat -c as a sub parameter of -f. I thought it was the default behaviour for the sql-cli too:

Parameters -f, -o, -s are correlated. That is parameters -o and -s are controlling outputs for reporter specified by the preceding -f parameter.

If you use:

-f=ut_documentation_reporter -o=test_results.log -s -c

it should work, because -c will be treated as a run parameter, not a -f sub parameter.

@jgebal
Copy link
Member Author

jgebal commented Aug 3, 2017

So what you are saying is that we cannot put the -c parameter anywhere we like.
That is nothing can go between -f -o -s sequence?
That is a bit restrictive. I'm not saying we must change this but this needs to be explicitly documented.
sql-cli just has a rule: associate the -s and -o to the preceding -f parameter. It does not care if there is some other parameter in between

@viniciusam
Copy link
Member

Yes, it's a bit restrictive but makes sense to have correlated parameters together. I would like to leave it as is and update the docs.

@jgebal
Copy link
Member Author

jgebal commented Aug 4, 2017

That solution will work just fine :)

@jgebal jgebal closed this as completed Aug 5, 2017
@viniciusam viniciusam mentioned this issue Aug 5, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jgebal @viniciusam