Add new config option so Catching "Ora Stuck" is not enabled by default

pesse · pesse · commit 260da9645919 · 2021-06-10T23:20:31.000+02:00
Reson for this that I have the assumption that catch is too greedy, leading to more abort- and retries than necessary.
diff --git a/src/main/java/org/utplsql/api/TestRunner.java b/src/main/java/org/utplsql/api/TestRunner.java
@@ -145,6 +145,11 @@ public TestRunner addTags(Collection<String> tags) {
         return this;
     }
 
+    public TestRunner catchOraStuck( boolean catchOraStuck ) {
+        this.options.catchOraStuck = catchOraStuck;
+        return this;
+    }
+
     public TestRunnerOptions getOptions() { return options; }
 
     private void delayedAddReporters() {
@@ -213,7 +218,7 @@ public void run(Connection conn) throws SQLException {
 
         TestRunnerStatement testRunnerStatement = null;
         try {
-            testRunnerStatement = initStatementWithTimeout(conn);
+            testRunnerStatement = ( options.catchOraStuck ) ? initStatementWithTimeout(conn) : initStatement(conn);
             logger.info("Running tests");
             testRunnerStatement.execute();
             logger.info("Running tests finished.");
@@ -227,6 +232,10 @@ public void run(Connection conn) throws SQLException {
         }
     }
 
+    private TestRunnerStatement initStatement( Connection conn ) throws SQLException {
+        return compatibilityProxy.getTestRunnerStatement(options, conn);
+    }
+
     private TestRunnerStatement initStatementWithTimeout( Connection conn ) throws OracleCreateStatmenetStuckException, SQLException {
         ExecutorService executor = Executors.newSingleThreadExecutor();
         Callable<TestRunnerStatement> callable = () -> compatibilityProxy.getTestRunnerStatement(options, conn);
diff --git a/src/main/java/org/utplsql/api/TestRunnerOptions.java b/src/main/java/org/utplsql/api/TestRunnerOptions.java
@@ -30,6 +30,7 @@ public class TestRunnerOptions {
     public boolean randomTestOrder = false;
     public Integer randomTestOrderSeed;
     public final Set<String> tags = new LinkedHashSet<>();
+    public boolean catchOraStuck = false;
 
     public String getTagsAsString() {
         return String.join(",", tags);
