We can add booleans now

pesse · pesse · commit b3d57796a3dc · 2019-10-20T17:38:06.000+02:00
Responsibility to build SQL fragment now also lies in the DynamicParameter
diff --git a/src/main/java/org/utplsql/api/db/DynamicParameterList.java b/src/main/java/org/utplsql/api/db/DynamicParameterList.java
@@ -20,6 +20,10 @@ public class DynamicParameterList {
 
     interface DynamicParameter {
         void setParam( CallableStatement statement, int index ) throws SQLException;
+
+        default String getSql( String key ) {
+            return key + " => ?";
+        }
     }
 
     private DynamicParameterList(LinkedHashMap<String, DynamicParameter> params) {
@@ -33,8 +37,8 @@ private DynamicParameterList(LinkedHashMap<String, DynamicParameter> params) {
      * @return comma-separated list of parameter identifiers
      */
     public String getSql() {
-        return params.keySet().stream()
-                .map(e -> e + " => ?")
+        return params.entrySet().stream()
+                .map(e ->  e.getValue().getSql(e.getKey()))
                 .collect(Collectors.joining(", "));
     }
 
@@ -116,7 +120,7 @@ public DynamicParameterListBuilder addIfNotEmpty(String identifier, Object[] val
         }
 
         public DynamicParameterListBuilder add(String identifier, Boolean value) {
-            params.put(identifier, null);
+            params.put(identifier, new DynamicBoolParameter(value));
             return this;
         }
 
@@ -167,6 +171,28 @@ public void setParam(CallableStatement statement, int index) throws SQLException
         }
     }
 
+    private static class DynamicBoolParameter implements DynamicParameter {
+        private final Boolean value;
+
+        DynamicBoolParameter( Boolean value ) {
+            this.value = value;
+        }
+
+        @Override
+        public void setParam(CallableStatement statement, int index) throws SQLException {
+            if ( value == null ) {
+                statement.setNull(index, Types.BOOLEAN);
+            } else {
+                statement.setInt(index, (value)?1:0);
+            }
+        }
+
+        @Override
+        public String getSql(String key) {
+            return key + " => (case ? when 1 then true else false)";
+        }
+    }
+
     private static class DynamicArrayParameter implements DynamicParameter {
         private final Object[] value;
         private final String customTypeName;
diff --git a/src/test/java/org/utplsql/api/db/DynamicParameterListTest.java b/src/test/java/org/utplsql/api/db/DynamicParameterListTest.java
@@ -68,7 +68,7 @@ void can_add_boolean() throws SQLException {
                     .add("a_bool", true)
                     .build();
 
-            assertEquals("a_param => (case ? when 1 then true else false)", paramList.getSql());
+            assertEquals("a_bool => (case ? when 1 then true else false)", paramList.getSql());
 
             paramList.setParamsStartWithIndex(stmt, 3);
             verify(stmt).setInt(3, 1);
