Remove helper comments

pesse · pesse · commit c0ca8cd9fc86 · 2019-10-21T15:00:02.000+02:00
diff --git a/src/main/java/org/utplsql/api/testRunner/DynamicTestRunnerStatement.java b/src/main/java/org/utplsql/api/testRunner/DynamicTestRunnerStatement.java
@@ -32,32 +32,14 @@ private DynamicTestRunnerStatement( Version utPlSQlVersion, OracleConnection con
     }
 
     private DynamicParameterList initParameterList() throws SQLException {
-        /*
-        "BEGIN " +
-                        "ut_runner.run(" +
-                        "a_paths                  => ?, " +
-                        "a_reporters              => ?, " +
-                        "a_color_console          => " + colorConsoleStr + ", " +
-                        "a_coverage_schemes       => ?, " +
-                        "a_source_file_mappings   => ?, " +
-                        "a_test_file_mappings     => ?, " +
-                        "a_include_objects        => ?, " +
-                        "a_exclude_objects        => ?, " +
-                        "a_fail_on_errors         => " + failOnErrors + ", " +
-                        "a_client_character_set   => ?, " +
-                        "a_random_test_order      => " + randomExecutionOrder + ", " +
-                        "a_random_test_order_seed => ?, "+
-                        "a_tags => ?"+
-                        "); " +
-                        "END;";
-         */
 
         Object[] sourceMappings = (options.sourceMappingOptions!=null)
                 ?FileMapper.buildFileMappingList(oracleConnection, options.sourceMappingOptions).toArray()
                 :null;
         Object[] testMappings = (options.testMappingOptions!=null)
                 ?FileMapper.buildFileMappingList(oracleConnection, options.testMappingOptions).toArray()
                 :null;
+
         return DynamicParameterList.builder()
                 .addIfNotEmpty("a_paths", options.pathList.toArray(), CustomTypes.UT_VARCHAR2_LIST, oracleConnection)
                 .addIfNotEmpty("a_reporters", options.reporterList.toArray(), CustomTypes.UT_REPORTERS, oracleConnection)
diff --git a/src/test/java/org/utplsql/api/testRunner/DynamicTestRunnerStatementTest.java b/src/test/java/org/utplsql/api/testRunner/DynamicTestRunnerStatementTest.java
@@ -47,24 +47,7 @@ void explore() throws SQLException {
         DynamicTestRunnerStatement testRunnerStatement = DynamicTestRunnerStatement
                 .forVersion(Version.V3_1_7, oracleConnection, options, callableStatement);
 
-        /*
-        "ut_runner.run(" +
-                        "a_paths                  => ?, " +
-                        "a_reporters              => ?, " +
-                        "a_color_console          => " + colorConsoleStr + ", " +
-                        "a_coverage_schemes       => ?, " +
-                        "a_source_file_mappings   => ?, " +
-                        "a_test_file_mappings     => ?, " +
-                        "a_include_objects        => ?, " +
-                        "a_exclude_objects        => ?, " +
-                        "a_fail_on_errors         => " + failOnErrors + ", " +
-                        "a_client_character_set   => ?, " +
-                        "a_random_test_order      => " + randomExecutionOrder + ", " +
-                        "a_random_test_order_seed => ?, "+
-                        "a_tags => ?"+
-                        "); " +
-                        "END;";
-         */
+        // Assert all parameters are set appropriately
         assertThat(testRunnerStatement.getSql(), containsString("a_paths => ?"));
         verify(callableStatement).setArray(1, null);
         verify(oracleConnection).createOracleArray(CustomTypes.UT_VARCHAR2_LIST, options.pathList.toArray());
@@ -109,7 +92,5 @@ void explore() throws SQLException {
 
         assertThat(testRunnerStatement.getSql(), containsString("a_tags => ?"));
         verify(callableStatement).setString(13, "WIP,long_running");
-
-
     }
 }
