install: fix the error message

sylvestre · sylvestre · commit 30dbdf7ac701 · 2025-11-08T10:58:46.000+01:00
should fix: tests/install/basic-1.sh
diff --git a/src/uu/install/locales/en-US.ftl b/src/uu/install/locales/en-US.ftl
@@ -22,7 +22,7 @@ install-help-default-context = set SELinux security context of destination file
 
 # Error messages
 install-error-dir-needs-arg = { $util_name } with -d requires at least one argument.
-install-error-create-dir-failed = failed to create { $path }
+install-error-create-dir-failed = cannot create directory { $path }
 install-error-chmod-failed = failed to chmod { $path }
 install-error-chmod-failed-detailed = { $path }: chmod failed with error { $error }
 install-error-chown-failed = failed to chown { $path }: { $error }
diff --git a/src/uu/install/src/install.rs b/src/uu/install/src/install.rs
@@ -472,7 +472,7 @@ fn directory(paths: &[OsString], b: &Behavior) -> UResult<()> {
                 // the default mode. Hence it is safe to use fs::create_dir_all
                 // and then only modify the target's dir mode.
                 if let Err(e) = fs::create_dir_all(path_to_create.as_path())
-                    .map_err_context(|| path_to_create.as_path().maybe_quote().to_string())
+                    .map_err_context(|| translate!("install-error-create-dir-failed", "path" => path_to_create.as_path().quote()))
                 {
                     show!(e);
                     continue;
diff --git a/tests/by-util/test_install.rs b/tests/by-util/test_install.rs
@@ -1013,7 +1013,7 @@ fn test_install_creating_leading_dir_fails_on_long_name() {
         .arg(source)
         .arg(at.plus(target.as_str()))
         .fails()
-        .stderr_contains("failed to create");
+        .stderr_contains("cannot create directory");
 }
 
 #[test]

Original file line number	Diff line number	Diff line change
`@@ -472,7 +472,7 @@ fn directory(paths: &[OsString], b: &Behavior) -> UResult<()> {`
`472`	`472`	`// the default mode. Hence it is safe to use fs::create_dir_all`
`473`	`473`	`// and then only modify the target's dir mode.`
`474`	`474`	`if let Err(e) = fs::create_dir_all(path_to_create.as_path())`
`475`		`- .map_err_context(\|\| path_to_create.as_path().maybe_quote().to_string())`
	`475`	`+ .map_err_context(\|\| translate!("install-error-create-dir-failed", "path" => path_to_create.as_path().quote()))`
`476`	`476`	`{`
`477`	`477`	`show!(e);`
`478`	`478`	`continue;`
Original file line number	Diff line number	Diff line change
`@@ -1013,7 +1013,7 @@ fn test_install_creating_leading_dir_fails_on_long_name() {`
`1013`	`1013`	`.arg(source)`
`1014`	`1014`	`.arg(at.plus(target.as_str()))`
`1015`	`1015`	`.fails()`
`1016`		`- .stderr_contains("failed to create");`
	`1016`	`+ .stderr_contains("cannot create directory");`
`1017`	`1017`	`}`
`1018`	`1018`
`1019`	`1019`	`#[test]`