hashsum: don't fail on dirs

Ada-Armstrong · Ada-Armstrong · commit d773b728ff9a · 2025-10-16T14:24:53.000-04:00
diff --git a/src/uu/hashsum/src/hashsum.rs b/src/uu/hashsum/src/hashsum.rs
@@ -11,7 +11,7 @@ use clap::value_parser;
 use clap::{Arg, ArgMatches, Command};
 use std::ffi::{OsStr, OsString};
 use std::fs::File;
-use std::io::{BufReader, Read, stdin};
+use std::io::{BufReader, ErrorKind, Read, stdin};
 use std::iter;
 use std::num::ParseIntError;
 use std::path::Path;
@@ -559,13 +559,31 @@ where
             Box::new(file_buf) as Box<dyn Read>
         });
 
-        let (sum, _) = digest_reader(
+        let sum = match digest_reader(
             &mut options.digest,
             &mut file,
             options.binary,
             options.output_bits,
-        )
-        .map_err_context(|| translate!("hashsum-error-failed-to-read-input"))?;
+        ) {
+            Ok((sum, _)) => sum,
+            Err(e) => match e.kind() {
+                ErrorKind::IsADirectory => {
+                    eprintln!(
+                        "{}: {}: {e}",
+                        options.binary_name,
+                        filename.to_string_lossy()
+                    );
+                    err_found = Some(ChecksumError::Io(e));
+                    continue;
+                }
+                _ => {
+                    return Err(
+                        e.map_err_context(|| translate!("hashsum-error-failed-to-read-input"))
+                    );
+                }
+            },
+        };
+
         let (escaped_filename, prefix) = escape_filename(filename);
         if options.tag {
             if options.algoname == "blake2b" {
diff --git a/tests/by-util/test_hashsum.rs b/tests/by-util/test_hashsum.rs
@@ -872,6 +872,26 @@ fn test_check_directory_error() {
         .stderr_contains(err_msg);
 }
 
+#[test]
+fn test_continue_after_directory_error() {
+    let scene = TestScenario::new(util_name!());
+    let at = &scene.fixtures;
+
+    at.mkdir("d");
+    at.touch("file");
+    #[cfg(not(windows))]
+    let err_msg = "md5sum: d: Is a directory (os error 21)\n";
+    #[cfg(windows)]
+    let err_msg = "md5sum: d: Permission denied\n";
+    scene
+        .ccmd("md5sum")
+        .arg("d")
+        .arg("file")
+        .fails()
+        .stdout_contains("d41d8cd98f00b204e9800998ecf8427e  file")
+        .stderr_contains(err_msg);
+}
+
 #[test]
 fn test_check_quiet() {
     let scene = TestScenario::new(util_name!());
