hashsum: don't fail on os errors

Ada-Armstrong · Ada-Armstrong · commit dab7554337f5 · 2025-10-22T13:43:33.000-04:00
diff --git a/src/uu/hashsum/src/hashsum.rs b/src/uu/hashsum/src/hashsum.rs
@@ -11,7 +11,7 @@ use clap::value_parser;
 use clap::{Arg, ArgMatches, Command};
 use std::ffi::{OsStr, OsString};
 use std::fs::File;
-use std::io::{BufReader, Read, stdin};
+use std::io::{BufReader, Error, Read, stdin};
 use std::iter;
 use std::num::ParseIntError;
 use std::path::Path;
@@ -25,7 +25,7 @@ use uucore::checksum::detect_algo;
 use uucore::checksum::digest_reader;
 use uucore::checksum::escape_filename;
 use uucore::checksum::perform_checksum_validation;
-use uucore::error::{FromIo, UResult};
+use uucore::error::UResult;
 use uucore::format_usage;
 use uucore::sum::{Digest, Sha3_224, Sha3_256, Sha3_384, Sha3_512, Shake128, Shake256};
 use uucore::translate;
@@ -533,6 +533,12 @@ fn uu_app(binary_name: &str) -> (Command, bool) {
     (command, is_hashsum_bin)
 }
 
+fn print_os_error(binary_name: &str, filename: &str, os_error: &Error) {
+    let err_string = os_error.to_string();
+    let clean_err_string = err_string.split(" (os error").next().unwrap_or(&err_string);
+    eprintln!("{binary_name}: {filename}: {clean_err_string}");
+}
+
 #[allow(clippy::cognitive_complexity)]
 fn hashsum<'a, I>(mut options: Options, files: I) -> UResult<()>
 where
@@ -564,13 +570,20 @@ where
             },
         );
 
-        let (sum, _) = digest_reader(
+        let sum = match digest_reader(
             &mut options.digest,
             &mut file,
             options.binary,
             options.output_bits,
-        )
-        .map_err_context(|| translate!("hashsum-error-failed-to-read-input"))?;
+        ) {
+            Ok((sum, _)) => sum,
+            Err(e) => {
+                print_os_error(options.binary_name, &filename.to_string_lossy(), &e);
+                err_found = Some(ChecksumError::Io(e));
+                continue;
+            }
+        };
+
         let (escaped_filename, prefix) = escape_filename(filename);
         if options.tag {
             if options.algoname == "blake2b" {
diff --git a/tests/by-util/test_hashsum.rs b/tests/by-util/test_hashsum.rs
@@ -872,6 +872,32 @@ fn test_check_directory_error() {
         .stderr_contains(err_msg);
 }
 
+#[test]
+fn test_continue_after_directory_error() {
+    let scene = TestScenario::new(util_name!());
+    let at = &scene.fixtures;
+
+    at.mkdir("d");
+    at.touch("file");
+    #[cfg(not(windows))]
+    let (out, err_msg) = (
+        "d41d8cd98f00b204e9800998ecf8427e  file\n",
+        "md5sum: d: Is a directory\n",
+    );
+    #[cfg(windows)]
+    let (out, err_msg) = (
+        "d41d8cd98f00b204e9800998ecf8427e *file\n",
+        "md5sum: d: Access is denied.\n",
+    );
+    scene
+        .ccmd("md5sum")
+        .arg("d")
+        .arg("file")
+        .fails()
+        .stdout_is(out)
+        .stderr_is(err_msg);
+}
+
 #[test]
 fn test_check_quiet() {
     let scene = TestScenario::new(util_name!());
