remove files that broke windows ci, updatedb: fix large negative deltas

Qelxiros · Qelxiros · commit cfe7b6d24373 · 2025-05-10T16:50:29.000-04:00
diff --git a/src/updatedb/mod.rs b/src/updatedb/mod.rs
@@ -220,7 +220,7 @@ impl Iterator for Frcoder<'_> {
         // if the prefix delta exceeds 0x7f, we use 0x80 to signal that the next two bytes comprise
         // the delta
         let mut out = Vec::new();
-        if diff > 0x7f {
+        if diff.abs() > 0x7f {
             out.push(0x80);
             out.extend((diff as i16).to_be_bytes());
         } else {
diff --git a/test_data_db b/test_data_db
diff --git a/tests/db_tests.rs b/tests/db_tests.rs
@@ -6,12 +6,18 @@
 
 mod common;
 
-use std::process::Command;
+use std::{fs::File, io, process::Command};
 
 use assert_cmd::{assert::OutputAssertExt, cargo::CommandCargoExt};
-use rstest::rstest;
-
-use crate::common::test_helpers::fix_up_slashes;
+use rstest::{fixture, rstest};
+
+#[fixture]
+fn add_special_files() -> io::Result<()> {
+    File::create("test_data/db/abc def")?;
+    File::create("test_data/db/abc\ndef")?;
+    File::create("test_data/db/✨sparkles✨")?;
+    Ok(())
+}
 
 #[cfg(not(windows))]
 const DB_FLAG: &str = "--database=test_data_db";
@@ -76,14 +82,16 @@ fn test_locate_non_existing() {
         .failure();
 }
 
-#[test]
+#[rstest]
 #[cfg(not(windows))]
-fn test_locate_statistics() {
-    Command::cargo_bin("locate")
-        .expect("couldn't find locate binary")
-        .args(["abbbc", "--statistics", DB_FLAG])
-        .assert()
-        .success();
+fn test_locate_statistics(add_special_files: io::Result<()>) {
+    if add_special_files.is_ok() {
+        Command::cargo_bin("locate")
+            .expect("couldn't find locate binary")
+            .args(["abbbc", "--statistics", DB_FLAG])
+            .assert()
+            .success();
+    }
 }
 
 #[rstest]
@@ -125,15 +133,12 @@ fn test_locate_all_regex() {
         .success();
 }
 
-#[test]
+#[rstest]
 #[cfg(not(windows))]
-fn test_updatedb() {
+fn test_updatedb(_add_special_files: io::Result<()>) {
     Command::cargo_bin("updatedb")
         .expect("couldn't find updatedb binary")
-        .args([
-            fix_up_slashes("--localpaths=./test_data"),
-            fix_up_slashes("--output=/dev/null"),
-        ])
+        .args(["--localpaths=./test_data", "--output=/dev/null"])
         .assert()
         .success();
 }
