fix: setfiles OOM exception (microsoft#1384)

railwayursin · web-flow · commit 30778a3b04ac · 2023-09-18T15:48:56.000-07:00
diff --git a/playwright/src/main/java/com/microsoft/playwright/impl/Utils.java b/playwright/src/main/java/com/microsoft/playwright/impl/Utils.java
@@ -174,18 +174,18 @@ static String mimeType(Path path) {
     return mimeType;
   }
 
-  static final int maxUplodBufferSize = 50 * 1024 * 1024;
+  static final long maxUploadBufferSize = 50 * 1024 * 1024;
 
   static boolean hasLargeFile(Path[] files) {
-    int totalSize = 0;
+    long totalSize = 0;
     for (Path file: files) {
       try {
         totalSize += Files.size(file);
       } catch (IOException e) {
         throw new PlaywrightException("Cannot get file size.", e);
       }
     }
-    return totalSize > maxUplodBufferSize;
+    return totalSize > maxUploadBufferSize;
   }
 
   static void addLargeFileUploadParams(Path[] files, JsonObject params, BrowserContextImpl context) {
@@ -216,11 +216,11 @@ static void addLargeFileUploadParams(Path[] files, JsonObject params, BrowserCon
   }
 
   static void checkFilePayloadSize(FilePayload[] files) {
-    int totalSize = 0;
+    long totalSize = 0;
     for (FilePayload file: files) {
       totalSize += file.buffer.length;
     }
-    if (totalSize > maxUplodBufferSize) {
+    if (totalSize > maxUploadBufferSize) {
       throw new PlaywrightException("Cannot set buffer larger than 50Mb, please write it to a file and pass its path instead.");
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -174,18 +174,18 @@ static String mimeType(Path path) {`
`174`	`174`	`return mimeType;`
`175`	`175`	`}`
`176`	`176`
`177`		`- static final int maxUplodBufferSize = 50 * 1024 * 1024;`
	`177`	`+ static final long maxUploadBufferSize = 50 * 1024 * 1024;`
`178`	`178`
`179`	`179`	`static boolean hasLargeFile(Path[] files) {`
`180`		`- int totalSize = 0;`
	`180`	`+ long totalSize = 0;`
`181`	`181`	`for (Path file: files) {`
`182`	`182`	`try {`
`183`	`183`	`totalSize += Files.size(file);`
`184`	`184`	`} catch (IOException e) {`
`185`	`185`	`throw new PlaywrightException("Cannot get file size.", e);`
`186`	`186`	`}`
`187`	`187`	`}`
`188`		`- return totalSize > maxUplodBufferSize;`
	`188`	`+ return totalSize > maxUploadBufferSize;`
`189`	`189`	`}`
`190`	`190`
`191`	`191`	`static void addLargeFileUploadParams(Path[] files, JsonObject params, BrowserContextImpl context) {`
`@@ -216,11 +216,11 @@ static void addLargeFileUploadParams(Path[] files, JsonObject params, BrowserCon`
`216`	`216`	`}`
`217`	`217`
`218`	`218`	`static void checkFilePayloadSize(FilePayload[] files) {`
`219`		`- int totalSize = 0;`
	`219`	`+ long totalSize = 0;`
`220`	`220`	`for (FilePayload file: files) {`
`221`	`221`	`totalSize += file.buffer.length;`
`222`	`222`	`}`
`223`		`- if (totalSize > maxUplodBufferSize) {`
	`223`	`+ if (totalSize > maxUploadBufferSize) {`
`224`	`224`	`throw new PlaywrightException("Cannot set buffer larger than 50Mb, please write it to a file and pass its path instead.");`
`225`	`225`	`}`
`226`	`226`	`}`