Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@HerbertsVaadin
Copy link
Contributor

Solves
#2002

Replaced Label component usage with appropriate:

  • Span - in case it is just used to display text
  • NativeLabel - in case label element is needed / justified.

Ignored Label usage within Charts API, since that's a whole different class, that is not deprecated.

@github-actions
Copy link

github-actions bot commented Oct 31, 2025

AI Language Review

  1. For "Running Spring Boot Applications":

    • In the "Handling SpringUI" section, ensure that all example comments clearly communicate their purpose and context.
    • In the "Considerations" section, review grammatical consistency, especially within composite sentences.
  2. For "Validating & Converting User Input":

    • In the "Custom Validation Error Messages" section, update consistency in component naming from Label to Span to align with HTML5 standards.
    • When bindings are discussed, ensure precise language around code execution order and its consequences.
  3. For "Binding Data to Forms":

    • In the "Example: Using the ReadOnlyHasValue helper class" section, change Label to Span to reflect semantic HTML use and maintain naming consistency.
  4. For "Binding to Components":

    • Ensure uniformity in component example names and reflect consistency with Vaadin's standards by changing Label to Span.
  5. For "Using Existing Components":

    • Confirm that component references (e.g., NativeLabel versus Label) correctly reflect updates and best practices in the context of the framework and semantic usage.
  6. For "Router Exception Handling":

    • Consistently use Span instead of Label to refer to text-based components for current frameworks.
  7. For "Using CDI Beans":

    • In the example for Using Components Injected into Templates, ensure a consistent reference to component naming conventions (Span instead of Label) within examples.
  8. For "Shadow Roots":

    • In the examples, reference to the span component should be updated from Label to Span for modern usage adherence.

For the rest of the files reviewed, I noticed no further modifications or errors that need addressing.

@peholmst peholmst added the target/main cherry pick to main branch label Nov 3, 2025
@HerbertsVaadin HerbertsVaadin force-pushed the chore/replace-label-usage branch from e16c8f2 to bcc485f Compare November 3, 2025 08:35
@HerbertsVaadin HerbertsVaadin merged commit 6abf20c into v24 Nov 3, 2025
4 checks passed
@HerbertsVaadin HerbertsVaadin deleted the chore/replace-label-usage branch November 3, 2025 08:38
vaadin-bot pushed a commit that referenced this pull request Nov 3, 2025
peholmst pushed a commit that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked-main target/main cherry pick to main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants