Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 40bbf1e

Browse files
shiftkeynulltoken
authored andcommitted
Drop optional parameters in BranchCollection.cs
1 parent b3386c9 commit 40bbf1e

File tree

1 file changed

+24
-2
lines changed

1 file changed

+24
-2
lines changed

LibGit2Sharp/BranchCollection.cs

Lines changed: 24 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,14 +106,25 @@ IEnumerator IEnumerable.GetEnumerator()
106106

107107
#endregion
108108

109+
/// <summary>
110+
/// Create a new local branch with the specified name
111+
/// </summary>
112+
/// <param name="name">The name of the branch.</param>
113+
/// <param name="committish">Revparse spec for the target commit.</param>
114+
/// <returns>A new <see cref="Branch"/>.</returns>
115+
public virtual Branch Add(string name, string committish)
116+
{
117+
return Add(name, committish, false);
118+
}
119+
109120
/// <summary>
110121
/// Create a new local branch with the specified name
111122
/// </summary>
112123
/// <param name="name">The name of the branch.</param>
113124
/// <param name="committish">Revparse spec for the target commit.</param>
114125
/// <param name="allowOverwrite">True to allow silent overwriting a potentially existing branch, false otherwise.</param>
115126
/// <returns>A new <see cref="Branch"/>.</returns>
116-
public virtual Branch Add(string name, string committish, bool allowOverwrite = false)
127+
public virtual Branch Add(string name, string committish, bool allowOverwrite)
117128
{
118129
Ensure.ArgumentNotNullOrEmptyString(name, "name");
119130
Ensure.ArgumentNotNullOrEmptyString(committish, "committish");
@@ -138,14 +149,25 @@ public virtual void Remove(Branch branch)
138149
}
139150
}
140151

152+
/// <summary>
153+
/// Rename an existing local branch
154+
/// </summary>
155+
/// <param name="branch">The current local branch.</param>
156+
/// <param name="newName">The new name the existing branch should bear.</param>
157+
/// <returns>A new <see cref="Branch"/>.</returns>
158+
public virtual Branch Rename(Branch branch, string newName)
159+
{
160+
return Rename(branch, newName, false);
161+
}
162+
141163
/// <summary>
142164
/// Rename an existing local branch
143165
/// </summary>
144166
/// <param name="branch">The current local branch.</param>
145167
/// <param name="newName">The new name the existing branch should bear.</param>
146168
/// <param name="allowOverwrite">True to allow silent overwriting a potentially existing branch, false otherwise.</param>
147169
/// <returns>A new <see cref="Branch"/>.</returns>
148-
public virtual Branch Rename(Branch branch, string newName, bool allowOverwrite = false)
170+
public virtual Branch Rename(Branch branch, string newName, bool allowOverwrite)
149171
{
150172
Ensure.ArgumentNotNull(branch, "branch");
151173
Ensure.ArgumentNotNullOrEmptyString(newName, "newName");

0 commit comments

Comments
 (0)