style fix

antoinerg · antoinerg · commit fc1aaba5c995 · 2019-06-04T13:47:56.000-04:00
diff --git a/src/traces/indicator/attributes.js b/src/traces/indicator/attributes.js
@@ -108,6 +108,7 @@ module.exports = {
     target: {
         valType: 'number',
         editType: 'calc',
+        dflt: 0,
         role: 'info',
         description: [
             'Sets a target value.'
diff --git a/src/traces/indicator/constants.js b/src/traces/indicator/constants.js
@@ -8,10 +8,10 @@
 
 'use strict';
 
-// TODO: turn those constants into attributes
 module.exports = {
     INCREASING_COLOR: '#3D9970',
     DECREASING_COLOR: '#FF4136',
+    // TODO: DIRSYMBOL into attributes
     DIRSYMBOL: {
         increasing: '▲',
         decreasing: '▼'
diff --git a/src/traces/indicator/plot.js b/src/traces/indicator/plot.js
@@ -12,13 +12,13 @@ var d3 = require('d3');
 
 var Lib = require('../../lib');
 var Drawing = require('../../components/drawing');
+var cn = require('./constants');
 // var Plots = require('../../plots/plots');
 // var Axes = require('../../plots/cartesian/axes');
 // var svgTextUtils = require('../../lib/svg_text_utils');
 //
 // // arc cotangent
 // function arcctg(x) { return Math.PI / 2 - Math.atan(x); }
-var cn = require('./constants');
 // var barPlot = require('../bar/plot').plot;
 
 module.exports = function plot(gd, cdModule, transitionOpts, makeOnCompleteCallback) {
@@ -71,7 +71,7 @@ module.exports = function plot(gd, cdModule, transitionOpts, makeOnCompleteCallb
             return (d.delta > 0 ? cn.DIRSYMBOL.increasing : cn.DIRSYMBOL.decreasing) + value;
         };
         var tickerFill = function(d) {
-            return d.delta > 0 ? trace.delta.increasing.color : trace.delta.decreasing.color;
+            return d.delta >= 0 ? trace.delta.increasing.color : trace.delta.decreasing.color;
         };
 
         // gauge related
@@ -82,19 +82,18 @@ module.exports = function plot(gd, cdModule, transitionOpts, makeOnCompleteCallb
         var theta = Math.PI / 2;
         var radius = Math.min(size.w / 2, size.h * 0.75);
         var innerRadius = cn.innerRadius * radius;
-
-        // bullet gauge
-        var isBullet = isGauge && trace.gauge.shape === 'bullet';
-
-        var isWide = !(size.h > radius);
-
         function valueToAngle(v) {
             var angle = (v - trace.min) / (trace.max - trace.min) * Math.PI - Math.PI / 2;
             if(angle < -theta) return -theta;
             if(angle > theta) return theta;
             return angle;
         }
 
+        // bullet gauge
+        var isBullet = isGauge && trace.gauge.shape === 'bullet';
+
+        var isWide = !(size.h > radius);
+
         // TODO: Move the following to defaults
         // Position elements
         var bignumberVerticalMargin, mainFontSize, bignumberX;
