Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: vega/altair
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.4.0
Choose a base ref
...
head repository: vega/altair
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.4.1
Choose a head ref
  • 17 commits
  • 23 files changed
  • 5 contributors

Commits on Aug 11, 2024

  1. Configuration menu
    Copy the full SHA
    0062e62 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Configuration menu
    Copy the full SHA
    95f5d31 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. docs: Explain the title frame attribute (#3537)

    * docs: Adds frame attribute.
    explains what is meant in this case by 'group', expands on meaning of other title attributes, and changes doc link reference from "customization" to "configuration", where the chart title properties are discussed.
    Resolves #3402
    
    * Shorten line length
    
    * Make a clearer distinction of what happens when the title frame is changed
    
    * Fix typo
    
    ---------
    
    Co-authored-by: Joel Ostblom <[email protected]>
    dsmedia and joelostblom authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    b996fa4 View commit details
    Browse the repository at this point in the history
  2. feat(typing): Generate Literal aliases in channels overload(s) (#…

    …3535)
    
    * feat(typing): Reuse `Literal`(s) in `channels` overloads
    
    * build: run `generate-schema-wrapper`
    dangotbanned authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    cfab660 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. ci: bump ruff>=0.6.0 (#3539)

    dangotbanned authored Aug 15, 2024
    Configuration menu
    Copy the full SHA
    4a4d20d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f8eb594 View commit details
    Browse the repository at this point in the history
  3. feat(typing): Generate Literal(s) using "const" (#3538)

    * feat(typing): Generate `Literal`(s) using `"const"`
    
    Previously only `"enum"` was considered, meaning `"const"` was represented as `str` - rather than a **single** valid `str` value.
    
    * build: run `generate-schema-wrapper`
    
    * fix(typing): Update `Chart` annotations to match now narrower schema
    
    * fix: Ensure rewrapped `Literal`(s) order is deterministic
    
    https://github.com/dangotbanned/altair/actions/runs/10404360936/job/28812668479
    
    * chore: Dummy to retrigger action
    dangotbanned authored Aug 15, 2024
    Configuration menu
    Copy the full SHA
    fa3c4c5 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Configuration menu
    Copy the full SHA
    635a2ec View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2024

  1. refactor: Simplify SchemaBase.copy (#3543)

    * refactor: Fix `C901` complexity in `SchemaBase.copy`
    
    The nested functions do not reference `self` and can be split out, much like `.to_dict` -> `_todict`.
    Saw this as a chance to add annotations as well. I think this helps illustrate that `.copy` is a noop for anything other than `SchemaBase | dict | list` - which I think might need to be addressed in the future.
    
    * refactor: Further simplify `SchemaBase.copy`
    
    10 lines shorter and is no longer constrained to `list` on the assert.
    May be slightly faster on `python<3.11` which do not have zero-cost exceptions https://docs.python.org/3.11/whatsnew/3.11.html#misc
    
    * refactor(perf): Merge identical `_shallow_copy` branches
    
    Remembered a related `ruff` rule [FURB145](https://docs.astral.sh/ruff/rules/slice-copy/).
    Wouldn't have made this fix, but likely would have led someone there
    
    * refactor(perf): Reduce `_deep_copy`
    
    - Initialize an empty set **once** at origin, rather than creating a new list per iteration
      - Renamed to `by_ref` in the new private function, to better describe the operation.
      - No change to public API.
    - Define a partial `copy` to reduce repetition
    - Use a genexpr for `args`, to avoid unpacking twice
    dangotbanned authored Aug 18, 2024
    Configuration menu
    Copy the full SHA
    c9f9438 View commit details
    Browse the repository at this point in the history
  2. fix(typing): Resolve misc type ignores in schemapi.py (#3545)

    * chore(typing): Add `pyright` ignores in `schemapi.py`
    
    * fix(typing): Address most issues in `_FromDict.from_dict`
    
    This method is far too dynamic to fix everything.
    Removed the need for one `mypy` specific ignore as well.
    
    * chore(typing): Ignore caught AttributeError
    
    * chore(typing): Add ignore in `validate_jsonschema`
    
    * fix(typing): Resolve `pyright` & `mypy` errors in `validate_jsonschema`
    
    * build: run `generate-schema-wrapper`
    dangotbanned authored Aug 18, 2024
    Configuration menu
    Copy the full SHA
    c7e1e83 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. test: Rename test to more specific `chart_error_example__four_errors_…

    …hide_fourth` (#3546)
    
    Working on a different branch I had to track down the comment explaining that this should display only 3 errors.
    The original name lead me to expect 4 errors
    dangotbanned authored Aug 19, 2024
    Configuration menu
    Copy the full SHA
    591bf40 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Configuration menu
    Copy the full SHA
    5de5138 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c984002 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2024

  1. refactor: Replace an indirect SchemaBase import (#3556)

    Spotted while writing an `__all__` for `schemapi.py` in #3547
    dangotbanned authored Aug 24, 2024
    Configuration menu
    Copy the full SHA
    49c8f9a View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. Configuration menu
    Copy the full SHA
    bf7fc29 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Configuration menu
    Copy the full SHA
    e543fbc View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Configuration menu
    Copy the full SHA
    1ad3648 View commit details
    Browse the repository at this point in the history
Loading