Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed match regex to support negative numbers #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 29, 2017
Merged

Fixed match regex to support negative numbers #96

merged 9 commits into from
Nov 29, 2017

Conversation

@yoavmmn
Copy link
Contributor

@yoavmmn yoavmmn commented Sep 13, 2017 •
edited
Loading

WHATSUP

The match regex was missing support for negative numbers. issue #70

Before

ms(ms(-10)) // undefined

returns undefined.
It seems natural to get a response like -10 if ms(-10) returns -10ms.

After

ms(ms(-10)) // -10
ms(ms(-.10)) // -0.10
ms(ms(-0.10)) // -0.10

Returns the appropriate result. it doesn't affect any other test and work with floats.

@yoavmmn yoavmmn mentioned this pull request Sep 13, 2017
Closed
@TooTallNate TooTallNate merged commit f0bc0a2 into vercel:master Nov 29, 2017
@TooTallNate
Copy link
Member

TooTallNate commented Nov 29, 2017

Thanks!

@snyk-bot snyk-bot mentioned this pull request Apr 8, 2020
Closed
@RedKnightToken RedKnightToken mentioned this pull request May 17, 2024
Open
@UlyssesDB UlyssesDB mentioned this pull request Aug 10, 2024
Open
@SebAllouche SebAllouche mentioned this pull request Sep 21, 2024
Open
@samueljochem samueljochem mentioned this pull request Nov 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yoavmmn @TooTallNate