Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit c286c02

Browse files
timneutkenstimneutkens
authored
Disable ncc cache instead of cache cleaning (#64804)
## What? `ncc cache clean` is running each time we call `ncc-compiled`. This PR removes the cache cleaning and instead just always passes `cache: false` to disable the built-in ncc cache. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Closes NEXT-3174
1 parent b914ad8 commit c286c02

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

‎packages/next/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@
8282
"prepublishOnly": "cd ../../ && turbo run build",
8383
"types": "tsc --declaration --emitDeclarationOnly --stripInternal --declarationDir dist",
8484
"typescript": "tsec --noEmit",
85-
"ncc-compiled": "ncc cache clean && taskr ncc"
85+
"ncc-compiled": "taskr ncc"
8686
},
8787
"taskr": {
8888
"requires": [

‎packages/next/taskfile-ncc.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ module.exports = function (task) {
2828
filename: file.base,
2929
minify: options.minify === false ? false : true,
3030
assetBuilds: true,
31+
cache: false,
3132
...options,
3233
}).then(({ code, assets }) => {
3334
Object.keys(assets).forEach((key) => {

0 commit comments

Comments
 (0)