Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Catch the exception thrown by the synchronization #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2019
Merged

Catch the exception thrown by the synchronization #156

merged 2 commits into from
May 27, 2019

Conversation

okou19900722
Copy link
Contributor

No description provided.

@okou19900722 okou19900722 mentioned this pull request May 21, 2019
Merged
@okou19900722 okou19900722 changed the title Backported Catch the exception thrown by the synchronization to 3.7 Catch the exception thrown by the synchronization May 21, 2019
@vietj vietj requested a review from codepitbull May 21, 2019 15:24
@vietj
Copy link
Contributor

vietj commented May 21, 2019

can you review this @codepitbull ?

@okou19900722
Copy link
Contributor Author

okou19900722 commented May 22, 2019 •
edited
Loading

We can switch the default branch to 3.8

@okou19900722 okou19900722 changed the base branch from 3.7 to 3.8 May 23, 2019 07:13
@codepitbull
Copy link

Sorry, just now got time to take a closer look.
PR looks good and I couldn't find a way that would cause problems with the current implementattion.

@codepitbull codepitbull merged commit d56e711 into vert-x3:3.8 May 27, 2019
@okou19900722
Copy link
Contributor Author

The callback in the unit test will never be executed until the modification

@okou19900722 okou19900722 deleted the 3.7 branch May 28, 2019 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codepitbull codepitbull Awaiting requested review from codepitbull

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@okou19900722 @vietj @codepitbull