Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixes #53: TS WITHOUT TZ are returned as String, TS WITH TZ are conve… #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2016

Conversation

pmlopes
Copy link
Member

@pmlopes pmlopes commented Aug 3, 2016

…rted to Instants properly JSON formatted

Fixes: #53
See: #53

KengoTODA added a commit to KengoTODA/vertx-mysql-postgresql-client that referenced this pull request Aug 4, 2016
Signed-off-by: Joern Bernhardt <[email protected]>
@Narigo
Copy link
Contributor

Narigo commented Aug 4, 2016

Looked good to me.

I've added a commit that moves the test into SQLTestBase and tweaked the compare of the two values for MySQL as it always kicks the milliseconds. Please have a look, if you're okay with it, I'll merge it @pmlopes

@pmlopes
Copy link
Member Author

pmlopes commented Aug 4, 2016

Thanks for verifying MySQL! Good to merge imo!

@Narigo Narigo merged commit f37e773 into master Aug 4, 2016
@Narigo Narigo removed the to review label Aug 4, 2016
@KengoTODA
Copy link

KengoTODA commented Aug 5, 2016

This test with MySQL fails in my local, how about in your environment?

testInstant(io.vertx.ext.asyncsql.MySQLClientTest)  Time elapsed: 0.021 sec  <<< ERROR!
com.github.mauricio.async.db.mysql.exceptions.MySQLException: Error 1292 - #22007 - Incorrect datetime value: '2016-08-05T02:37:07.959Z' for column 'instant' at row 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants